Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 29338481: Issue 3705 - Don't rely on info.platform when checking for availability of the chrome.* API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Oleksandr
Modified:
3 years, 8 months ago
Reviewers:
kzar, Sebastian Noack
Visibility:
Public.

Description

Issue 3705 - Don't rely on info.platform when checking for availability of the chrome.* API Repository: hg.adblockplus.org/adblockpluschrome/ It might make sense to introduce something like isChromeLike() method, but at this point it could be an overkill, not sure.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/notificationHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M webrequest.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Oleksandr
3 years, 8 months ago (2016-03-17 06:54:16 UTC) #1
Sebastian Noack
3 years, 8 months ago (2016-03-17 11:24:36 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5