Issue 29338481: Issue 3705 - Don't rely on info.platform when checking for availability of the chrome.* API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338481: Issue 3705 - Don't rely on info.platform when checking for availability of the chrome.* API (Closed)

Created:
March 17, 2016, 6:54 a.m. by Oleksandr

Modified:
March 21, 2016, 2:38 p.m.

Reviewers:
Sebastian Noack, kzar

Visibility:
Public.

Description

Issue 3705 - Don't rely on info.platform when checking for availability of the chrome.* API Repository: hg.adblockplus.org/adblockpluschrome/ It might make sense to introduce something like isChromeLike() method, but at this point it could be an overkill, not sure.

Patch Set 1 #

Created: March 17, 2016, 6:54 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	lib/notificationHelper.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/prefs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrequest.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages