Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340602: Issue 2596 - change adblockplus to adblockpluscore (Closed)

Created:
April 19, 2016, 8:50 p.m. by sergei
Modified:
May 17, 2016, 3:11 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke, Eric, René Jeschke
Visibility:
Public.

Description

It also fixes #3561 because the race condition is fixed in adblockpluscore.

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -284 lines) Patch
M convert_js.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M dependencies View 1 chunk +2 lines, -2 lines 0 comments Download
M ensure_dependencies.py View 1 chunk +277 lines, -266 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +13 lines, -12 lines 0 comments Download
M test/FilterEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
April 19, 2016, 8:51 p.m. (2016-04-19 20:51:56 UTC) #1
Oleksandr
May 17, 2016, 12:25 p.m. (2016-05-17 12:25:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld