Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1280)

Issue 29342903: Issue 4059 - Adapt the manifest for Edge (awaiting commit) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Oleksandr
Modified:
3 years, 1 month ago
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 4059 - Adapt the manifest for Edge

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use metadata for author data #

Total comments: 1

Patch Set 3 : Remove the whitespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M manifest.json.tmpl View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
Oleksandr
3 years, 1 month ago (2016-05-23 05:14:40 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29342903/diff/29342904/manifest.json.tmpl File manifest.json.tmpl (right): https://codereview.adblockplus.org/29342903/diff/29342904/manifest.json.tmpl#newcode17 manifest.json.tmpl:17: "author": "__MSG_author__", This string should come from the metadata ...
3 years, 1 month ago (2016-05-23 10:58:11 UTC) #2
Oleksandr
3 years, 1 month ago (2016-05-27 19:52:31 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29342903/diff/29345105/manifest.json.tmpl File manifest.json.tmpl (right): https://codereview.adblockplus.org/29342903/diff/29345105/manifest.json.tmpl#newcode17 manifest.json.tmpl:17: "author": {{ metadata.get('general', 'author')|json }}, Nit: Mimd removing the ...
3 years, 1 month ago (2016-05-27 20:52:30 UTC) #4
Oleksandr
3 years, 1 month ago (2016-05-28 08:04:07 UTC) #5
Sebastian Noack
3 years, 1 month ago (2016-05-28 08:07:55 UTC) #6
LGTM. But before landing this in buildtools, we have to adapt metadata.common in
upstream adblockpluschrome, since "author" isnt there yet, however the server
will immediately start using the new buildtools version.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5