Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29342903: Issue 4059 - Adapt the manifest for Edge (awaiting commit) (Closed)

Created:
May 23, 2016, 5:13 a.m. by Oleksandr
Modified:
June 1, 2016, 12:24 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Issue 4059 - Adapt the manifest for Edge

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use metadata for author data #

Total comments: 1

Patch Set 3 : Remove the whitespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M manifest.json.tmpl View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
Oleksandr
May 23, 2016, 5:14 a.m. (2016-05-23 05:14:40 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29342903/diff/29342904/manifest.json.tmpl File manifest.json.tmpl (right): https://codereview.adblockplus.org/29342903/diff/29342904/manifest.json.tmpl#newcode17 manifest.json.tmpl:17: "author": "__MSG_author__", This string should come from the metadata ...
May 23, 2016, 10:58 a.m. (2016-05-23 10:58:11 UTC) #2
Oleksandr
May 27, 2016, 7:52 p.m. (2016-05-27 19:52:31 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29342903/diff/29345105/manifest.json.tmpl File manifest.json.tmpl (right): https://codereview.adblockplus.org/29342903/diff/29345105/manifest.json.tmpl#newcode17 manifest.json.tmpl:17: "author": {{ metadata.get('general', 'author')|json }}, Nit: Mimd removing the ...
May 27, 2016, 8:52 p.m. (2016-05-27 20:52:30 UTC) #4
Oleksandr
May 28, 2016, 8:04 a.m. (2016-05-28 08:04:07 UTC) #5
Sebastian Noack
May 28, 2016, 8:07 a.m. (2016-05-28 08:07:55 UTC) #6
LGTM. But before landing this in buildtools, we have to adapt metadata.common in
upstream adblockpluschrome, since "author" isnt there yet, however the server
will immediately start using the new buildtools version.

Powered by Google App Engine
This is Rietveld