Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29345235: Issue 4085 - Fallback to XMLHttpRequest if Fetch API is not supported in Edge (Closed)

Created:
May 29, 2016, 2:33 a.m. by Oleksandr
Modified:
Aug. 18, 2017, 11:22 a.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 4085 - Fallback to XMLHttpRequest if Fetch API is not supported in Edge

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/polyfills/fetch.js View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 2
Oleksandr
Fetch API is under the flag in Microsoft Edge, so this workaround is still needed ...
Aug. 22, 2016, 9:34 a.m. (2016-08-22 09:34:48 UTC) #1
kzar
Aug. 22, 2016, 3:47 p.m. (2016-08-22 15:47:20 UTC) #2
https://codereview.adblockplus.org/29345235/diff/29345236/lib/polyfills/fetch.js
File lib/polyfills/fetch.js (right):

https://codereview.adblockplus.org/29345235/diff/29345236/lib/polyfills/fetch...
lib/polyfills/fetch.js:69: if ((protocol == "chrome-extension:") || (protocol ==
"ms-browser-extension:"))
Nit: Mind wrapping this at the || to avoid the line being too long?

if ((protocol == "chrome-extension:") ||
    (protocol == "ms-browser-extension:"))
  ...
...

https://codereview.adblockplus.org/29345235/diff/29345236/lib/polyfills/fetch...
lib/polyfills/fetch.js:69: if ((protocol == "chrome-extension:") || (protocol ==
"ms-browser-extension:"))
Not sure what Sebastian thinks but maybe we should rather check if protocol ends
with "-extension:"? Then we could avoid doing two checks and the protocol
variable.

Powered by Google App Engine
This is Rietveld