Issue 29345403: Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29345403: Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately (Closed)

Created:
May 31, 2016, 11:36 a.m. by Wladimir Palant

Modified:
May 31, 2016, 3:07 p.m.

Reviewers:
kzar

CC:
Sebastian Noack

Visibility:
Public.

Description

Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately Repository: hg.adblockplus.org/jshydra

Patch Set 2 : Automatically load some modules if specified #

Total comments: 3

Patch Set 3 : Renamed callback #

Created: May 31, 2016, 2:53 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
A	autotest/test_abprewrite_autoload.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	autotest/test_abprewrite_autoload.js.expected	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	autotest/test_abprewrite_module.js.expected	View		1 chunk	+1 line, -1 line	0 comments	Download
M	jshydra.js	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	scripts/abprewrite.js	View	1 2	3 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Wladimir Palant

I added autoload option making sure that some modules are loaded automatically - as requested ...

May 31, 2016, 1:47 p.m. (2016-05-31 13:47:37 UTC) #2

kzar

Well I'm not too familiar with JSHydra, I also don't have time to go and ...

May 31, 2016, 2:43 p.m. (2016-05-31 14:43:15 UTC) #3

Wladimir Palant

https://codereview.adblockplus.org/29345403/diff/29345417/jshydra.js File jshydra.js (right): https://codereview.adblockplus.org/29345403/diff/29345417/jshydra.js#newcode44 jshydra.js:44: if (typeof done_processing == "function") On 2016/05/31 14:43:15, kzar ...

May 31, 2016, 2:54 p.m. (2016-05-31 14:54:02 UTC) #4

kzar

May 31, 2016, 2:56 p.m. (2016-05-31 14:56:28 UTC) #5

LGTM

https://codereview.adblockplus.org/29345403/diff/29345417/jshydra.js
File jshydra.js (right):

https://codereview.adblockplus.org/29345403/diff/29345417/jshydra.js#newcode44
jshydra.js:44: if (typeof done_processing == "function")
On 2016/05/31 14:54:02, Wladimir Palant wrote:
> On 2016/05/31 14:43:15, kzar wrote:
> > Nit: Won't this function always exist?
> 
> As is, JSHydra is a general-purpose tool - it can run any processing scripts,
> not just ours. Now of course it's unlikely that anybody will use our JSHydra
> fork but I'd prefer to keep it generic.
> 
> > Also how about calling it post_processing
> > instead of done_processing?
> 
> Sure.

Fair enough.

Expand All Messages | Collapse All Messages