Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 29348062: Issue 4023 - The logic for splitting up storage.local into 1MB chunks does not work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Oleksandr
Modified:
3 years, 4 months ago
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

This would be the solution when Edge would support unlimitedStorage permission. As it is now, there is a limit of 5Mb for storage in total. Combined with the fact that objects get serialized in json and written using UTF-16 (2 bytes per character) this doesn't look like a really a viable solution.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -60 lines) Patch
M lib/io.js View 4 chunks +32 lines, -60 lines 0 comments Download
M metadata.common View 1 chunk +2 lines, -0 lines 0 comments Download
A qunit/tests/io.js View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Oleksandr
3 years, 7 months ago (2016-07-20 22:22:09 UTC) #1
Sebastian Noack
Did you try out whether the same limitations apply when using localStorage?
3 years, 7 months ago (2016-07-20 23:06:09 UTC) #2
Oleksandr
On 2016/07/20 23:06:09, Sebastian Noack wrote: > Did you try out whether the same limitations ...
3 years, 7 months ago (2016-07-21 07:53:18 UTC) #3
Sebastian Noack
On 2016/07/21 07:53:18, Oleksandr wrote: > On 2016/07/20 23:06:09, Sebastian Noack wrote: > > Did ...
3 years, 7 months ago (2016-07-22 04:12:38 UTC) #4
kzar
3 years, 5 months ago (2016-09-14 11:12:26 UTC) #5
Since we're now using localStorage this review can be closed right?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5