Issue 4023 - The logic for splitting up storage.local into 1MB chunks does not work

This would be the solution when Edge would support unlimitedStorage permission. As it is now, there is a limit of 5Mb for storage in total. Combined with the fact that objects get serialized in json and written using UTF-16 (2 bytes per character) this doesn't look like a really a viable solution.

[Sebastian Noack, 2016-07-20 23:06:09]

Did you try out whether the same limitations apply when using localStorage?

[Oleksandr, 2016-07-21 07:53:18]

On 2016/07/20 23:06:09, Sebastian Noack wrote:
> Did you try out whether the same limitations apply when using localStorage?

There is a limitation of 10Mb (1040000 bytes) in localStorage. No 1Mb per item
limit. However I understand it is undesirable to use localStorage, so I
submitted this in case support for 'unlimitedStorage' is implemented in Edge.
I'll submit a separate review with a move to localStorage. This review is not
for commit.

[Sebastian Noack, 2016-07-22 04:12:38]

On 2016/07/21 07:53:18, Oleksandr wrote:
> On 2016/07/20 23:06:09, Sebastian Noack wrote:
> > Did you try out whether the same limitations apply when using localStorage?
> 
> There is a limitation of 10Mb (1040000 bytes) in localStorage. No 1Mb per item
> limit. However I understand it is undesirable to use localStorage, so I
> submitted this in case support for 'unlimitedStorage' is implemented in Edge.
> I'll submit a separate review with a move to localStorage. This review is not
> for commit.

Well, the 1MB per item limitation will eventually be removed too, hopefully not
any later than unlimitedStorage is going to be supported. And for now it seems
using localStorage might be the only suitable workaround anyway.

[kzar, 2016-09-14 11:12:26]

Since we're now using localStorage this review can be closed right?