Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349840: Issue 4294 - Removed feature section from first-run page (Closed)

Created:
Aug. 16, 2016, 9:59 a.m. by Thomas Greiner
Modified:
Aug. 18, 2016, 1:16 p.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

Note that the /skin/features/ directory will also be removed but Rietveld doesn't reflect that.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -332 lines) Patch
M firstRun.html View 1 chunk +0 lines, -55 lines 3 comments Download
M firstRun.js View 4 chunks +0 lines, -70 lines 0 comments Download
M locale/en-US/firstRun.json View 2 chunks +0 lines, -27 lines 3 comments Download
M skin/firstRun.css View 3 chunks +0 lines, -180 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Aug. 16, 2016, 10:01 a.m. (2016-08-16 10:01:24 UTC) #1
saroyanm
Looks fine, just two comments. https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html File firstRun.html (left): https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldcode115 firstRun.html:115: <div class="feature-image feature-social-image"></div> What ...
Aug. 16, 2016, noon (2016-08-16 12:00:13 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html File firstRun.html (left): https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldcode115 firstRun.html:115: <div class="feature-image feature-social-image"></div> On 2016/08/16 12:00:11, saroyanm wrote: > ...
Aug. 16, 2016, 1:12 p.m. (2016-08-16 13:12:00 UTC) #3
saroyanm
Aug. 16, 2016, 1:20 p.m. (2016-08-16 13:20:32 UTC) #4
LGTM

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html
File firstRun.html (left):

https://codereview.adblockplus.org/29349840/diff/29349841/firstRun.html#oldco...
firstRun.html:115: <div class="feature-image feature-social-image"></div>
On 2016/08/16 13:12:00, Thomas Greiner wrote:
> On 2016/08/16 12:00:11, saroyanm wrote:
> > What about feature images themselves ? 
> > I think the skin/features directory can be deleted completely.
> 
> I mentioned this in the review description. Admittingly, I added it after I
sent
> out the email because I forgot it before. :)
> 
> But yes, that will be removed. 

OOps sorry, missed that.

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
File locale/en-US/firstRun.json (left):

https://codereview.adblockplus.org/29349840/diff/29349841/locale/en-US/firstR...
locale/en-US/firstRun.json:26: "firstRun_feature_malware": {
On 2016/08/16 13:12:00, Thomas Greiner wrote:
> On 2016/08/16 12:00:12, saroyanm wrote:
> > What about translations ? Are they being removed by some script ?
> 
> Any language files apart from the U.S. english ones are automatically created
so
> if unused texts aren't being removed, I'd consider it to be an issue with the
> script that creates those.

Acknowledged.

Powered by Google App Engine
This is Rietveld