Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 29350042: Issue 4023 - Move storage of subscription lists to localStorage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Oleksandr
Modified:
3 years, 5 months ago
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 4023 - Move storage of subscription lists to localStorage

Patch Set 1 #

Total comments: 37

Patch Set 2 : Cleanup #

Total comments: 17

Patch Set 3 : Fix formatting #

Total comments: 1

Patch Set 4 : Add full stop after a comment and fix formatting #

Total comments: 3

Patch Set 5 : Make sure entry["compressed"] is truthful #

Unified diffs Side-by-side diffs Delta from patch set Stats (+654 lines, -60 lines) Patch
M chrome/ext/background.js View 1 chunk +1 line, -3 lines 0 comments Download
M lib/io.js View 1 2 3 4 4 chunks +46 lines, -52 lines 0 comments Download
A lib/lz-string.js View 1 chunk +506 lines, -0 lines 0 comments Download
M lib/prefs.js View 1 chunk +4 lines, -1 line 0 comments Download
M metadata.common View 2 chunks +4 lines, -0 lines 0 comments Download
A qunit/tests/io.js View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
M safari/ext/background.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13
Oleksandr
3 years, 6 months ago (2016-08-22 09:33:31 UTC) #1
kzar
Dumb question but are these changes (and the other review) for https://bitbucket.org/sebastian_noack/adblockplusedge or the main ...
3 years, 6 months ago (2016-08-22 13:20:16 UTC) #2
kzar
https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js File lib/io.js (left): https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js#oldcode78 lib/io.js:78: copyFile: function(fromFile, toFile, callback) copyFile and renameFile have been ...
3 years, 6 months ago (2016-08-22 15:38:34 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js#newcode88 lib/io.js:88: if (typeof browser == "undefined") On 2016/08/22 15:38:32, kzar ...
3 years, 6 months ago (2016-08-22 16:49:20 UTC) #4
Oleksandr
https://codereview.adblockplus.org/29350042/diff/29350043/lib/lz-string.js File lib/lz-string.js (right): https://codereview.adblockplus.org/29350042/diff/29350043/lib/lz-string.js#newcode3 lib/lz-string.js:3: // under the terms of the WTFPL, Version 2 ...
3 years, 6 months ago (2016-08-25 02:02:38 UTC) #5
kzar
Looking much better, mostly nits left in the code now. A couple of general things ...
3 years, 5 months ago (2016-08-30 14:13:03 UTC) #6
Oleksandr
Patch set 3 : fix formatting. https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js File lib/io.js (left): https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js#oldcode78 lib/io.js:78: copyFile: function(fromFile, toFile, ...
3 years, 5 months ago (2016-08-31 21:54:38 UTC) #7
kzar
https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js File lib/io.js (left): https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js#oldcode78 lib/io.js:78: copyFile: function(fromFile, toFile, callback) On 2016/08/31 21:54:35, Oleksandr wrote: ...
3 years, 5 months ago (2016-09-01 12:57:38 UTC) #8
Oleksandr
Patch Set 4 : Add full stop after a comment and fix formatting https://codereview.adblockplus.org/29350042/diff/29350043/lib/io.js File ...
3 years, 5 months ago (2016-09-02 04:12:26 UTC) #9
kzar
LGTM. Sebastian do you want to review this one too? (You missed replying to a ...
3 years, 5 months ago (2016-09-02 08:57:49 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29350042/diff/29350407/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29350042/diff/29350407/lib/io.js#newcode65 lib/io.js:65: if ("compressed" in entry) Please check for entry["compressed"], otherwise, ...
3 years, 5 months ago (2016-09-08 15:27:22 UTC) #11
Oleksandr
Patch Set: Make sure entry["compressed"] is truthful https://codereview.adblockplus.org/29350042/diff/29350407/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29350042/diff/29350407/lib/io.js#newcode91 lib/io.js:91: let processedData ...
3 years, 5 months ago (2016-09-08 23:51:57 UTC) #12
Sebastian Noack
3 years, 5 months ago (2016-09-09 13:44:17 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5