Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 29350158: Issue 4353 - Update Js Shell to version 45 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by kzar
Modified:
3 years, 2 months ago
Visibility:
Public.

Description

Issue 4353 - Update Js Shell to version 45 Note: In order to build adblockpluschrome with Js Shell 45 we will also need to update the adblockpluscore and adblockplustests dependencies and wait for these changes to land: https://codereview.adblockplus.org/29350286/ https://codereview.adblockplus.org/29350155/

Patch Set 1 #

Total comments: 7

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M abp_rewrite.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/abprewrite.js View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/astDecompile.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
kzar
Patch Set 1
3 years, 2 months ago (2016-08-24 11:18:45 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29350158/diff/29350159/utils.py File utils.py (right): https://codereview.adblockplus.org/29350158/diff/29350159/utils.py#newcode17 utils.py:17: "/2016/05/2016-05-29-00-15-03-%s/jsshell-%%s.zip" % JSSHELL_DIR) Nit: While changing this line mind ...
3 years, 2 months ago (2016-08-24 11:27:55 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js File scripts/abprewrite.js (right): https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js#newcode131 scripts/abprewrite.js:131: ast = global[func](ast); How is this working now? You ...
3 years, 2 months ago (2016-08-24 14:08:36 UTC) #3
kzar
https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js File scripts/abprewrite.js (right): https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js#newcode131 scripts/abprewrite.js:131: ast = global[func](ast); On 2016/08/24 14:08:36, Wladimir Palant wrote: ...
3 years, 2 months ago (2016-08-24 14:25:21 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js File scripts/abprewrite.js (right): https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js#newcode131 scripts/abprewrite.js:131: ast = global[func](ast); On 2016/08/24 14:25:20, kzar wrote: > ...
3 years, 2 months ago (2016-08-24 14:45:17 UTC) #5
kzar
Patch Set 2 : Rebased. (I haven't tested this since the rebase as I'm waiting ...
3 years, 2 months ago (2016-09-13 13:35:20 UTC) #6
Wladimir Palant
LGTM https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js File scripts/abprewrite.js (right): https://codereview.adblockplus.org/29350158/diff/29350159/scripts/abprewrite.js#newcode131 scripts/abprewrite.js:131: ast = global[func](ast); On 2016/09/13 13:35:20, kzar wrote: ...
3 years, 2 months ago (2016-09-13 14:23:00 UTC) #7
Sebastian Noack
LGTM. However, I just noticed that jsshell has to be updated manually on the server, ...
3 years, 2 months ago (2016-09-13 14:47:09 UTC) #8
Wladimir Palant
3 years, 2 months ago (2016-09-13 15:06:35 UTC) #9
On 2016/09/13 14:47:09, Sebastian Noack wrote:
> However, I just noticed that jsshell has to be updated manually on the server,
> since this code isn't used if the SPIDERMONKEY_BINARY environment variable is
> set, see #4097. Hindsight, it would perhaps made more sense to just override
the
> directory where it caches the jsshell builds into.

Probably a good idea. For now I downloaded the new jsshell version however and
will update the settings once this is pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5