Issue 4547 - ABP edge 0.9.8 re-adds easylist

This is slightly bizzare - I have tried to figure out why this was commented out, but I did not find any reasons. It was commented out in the original code Microsoft sent us too, so it seems to be a long living bug already.

[Sebastian Noack, 2016-10-21 22:57:56]

LGTM. How did that code got commented out? I don't recall this being a change we
did in between 0.9.6 and 0.9.7.

(Please prepare a devbuild, I will submit it tomorrow, I'm currently on the
phone)

[Oleksandr, 2016-10-21 23:17:31]

On 2016/10/21 22:57:56, Sebastian Noack wrote:
> LGTM. How did that code got commented out? I don't recall this being a change
we
> did in between 0.9.6 and 0.9.7.
> 
> (Please prepare a devbuild, I will submit it tomorrow, I'm currently on the
> phone)

This was commented out all the way in 0.9.4. That is the result of an upgrade to
chrome version 1.12 that was done when you guys went to Microsoft, I think.
Could have been just an accidental "temporary" commenting out, I guess.

[Sebastian Noack, 2016-10-22 00:52:10]

On 2016/10/21 23:17:31, Oleksandr wrote:
> On 2016/10/21 22:57:56, Sebastian Noack wrote:
> > LGTM. How did that code got commented out? I don't recall this being a
change
> we
> > did in between 0.9.6 and 0.9.7.
> > 
> > (Please prepare a devbuild, I will submit it tomorrow, I'm currently on the
> > phone)
> 
> This was commented out all the way in 0.9.4. That is the result of an upgrade
to
> chrome version 1.12 that was done when you guys went to Microsoft, I think.
> Could have been just an accidental "temporary" commenting out, I guess.

I think you are right, this logic has been disabled ever since (even before
0.9.4) since initially EasyList was downloaded on every startup (by separate
code) and other filter lists weren't supported. I'm still surprised that it
didn't caused a bug that was noticed before the last release.