Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(427)

Issue 29366773: Issue 4698 - Popup window is broken in Edge (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Oleksandr
Modified:
3 years, 3 months ago
Reviewers:
Sebastian Noack, kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 4698 - Popup window is broken in Edge

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/ext/popup.js View 1 chunk +2 lines, -0 lines 0 comments Download
M stats.js View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4
Oleksandr
https://codereview.adblockplus.org/29366773/diff/29366774/stats.js File stats.js (right): https://codereview.adblockplus.org/29366773/diff/29366774/stats.js#newcode99 stats.js:99: i18n.setElementText(statsPage, "stats_label_page", blockedPage); Edge throws if passed an array ...
3 years, 4 months ago (2016-12-05 00:27:36 UTC) #1
kzar
https://codereview.adblockplus.org/29366773/diff/29366774/stats.js File stats.js (right): https://codereview.adblockplus.org/29366773/diff/29366774/stats.js#newcode99 stats.js:99: i18n.setElementText(statsPage, "stats_label_page", blockedPage); On 2016/12/05 00:27:36, Oleksandr wrote: > ...
3 years, 4 months ago (2016-12-05 12:22:52 UTC) #2
Oleksandr
On 2016/12/05 12:22:52, kzar wrote: > https://codereview.adblockplus.org/29366773/diff/29366774/stats.js > File stats.js (right): > > https://codereview.adblockplus.org/29366773/diff/29366774/stats.js#newcode99 > ...
3 years, 4 months ago (2016-12-05 14:48:18 UTC) #3
kzar
3 years, 4 months ago (2016-12-05 15:46:10 UTC) #4
On 2016/12/05 14:48:18, Oleksandr wrote:
> It looks like it is a problem only if you call getMessage from a
contentScript.
> I have filed a Microsoft Edge bug here: 
> https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10063392/

Thanks for filing the Edge issue, I added a link to it from our issue as well.
BTW please reply to inline comments inline, otherwise it's hard to keep a
conversation going.

Assuming this change is for the edge branch then LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5