Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367151: Issue 4721 - Use IndexedDB for storage in Edge (Closed)

Created:
Dec. 9, 2016, 6:38 a.m. by Oleksandr
Modified:
Dec. 14, 2016, 1:54 a.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 4721 - Use IndexedDB for storage in Edge

Patch Set 1 #

Total comments: 21

Patch Set 2 : Use arrow functions. Remove code duplication. Address comments and nits. #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
A edge/ext/background.js View 1 1 chunk +79 lines, -0 lines 6 comments Download
A edge/localforage.min.js View 1 chunk +7 lines, -0 lines 0 comments Download
M metadata.edge View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9
Oleksandr
Dec. 9, 2016, 6:40 a.m. (2016-12-09 06:40:18 UTC) #1
kzar
I have not reviewed this yet but I agree with Sebastian here. I think a ...
Dec. 12, 2016, 12:16 p.m. (2016-12-12 12:16:40 UTC) #2
kzar
On 2016/12/12 12:16:40, kzar wrote: > I have not reviewed this yet but I agree ...
Dec. 12, 2016, 1:54 p.m. (2016-12-12 13:54:49 UTC) #3
kzar
https://codereview.adblockplus.org/29367151/diff/29367152/README.md File README.md (right): https://codereview.adblockplus.org/29367151/diff/29367152/README.md#newcode54 README.md:54: For Edge you should load _devenv.edge_ as an unpacked ...
Dec. 12, 2016, 2:17 p.m. (2016-12-12 14:17:50 UTC) #4
Oleksandr
Patch Set 2 : Use arrow functions. Remove code duplication. Address comments and nits. https://codereview.adblockplus.org/29367151/diff/29367152/README.md ...
Dec. 13, 2016, 6:21 a.m. (2016-12-13 06:21:19 UTC) #5
kzar
https://codereview.adblockplus.org/29367151/diff/29367152/edge/ext/background.js File edge/ext/background.js (right): https://codereview.adblockplus.org/29367151/diff/29367152/edge/ext/background.js#newcode25 edge/ext/background.js:25: var promisedValues = keys.map(function(key) On 2016/12/13 06:21:18, Oleksandr wrote: ...
Dec. 13, 2016, 10:24 a.m. (2016-12-13 10:24:05 UTC) #6
Sebastian Noack
This seems to be a whole different approach than what we did in adblockplusedgems: https://hg.adblockplus.org/adblockplusedgems/rev/5a8b109447d3 ...
Dec. 13, 2016, 10:57 a.m. (2016-12-13 10:57:07 UTC) #7
kzar
On 2016/12/13 10:57:07, Sebastian Noack wrote: > Please just use the existing code we have ...
Dec. 13, 2016, 11:11 a.m. (2016-12-13 11:11:25 UTC) #8
Oleksandr
Dec. 14, 2016, 1:54 a.m. (2016-12-14 01:54:06 UTC) #9

Powered by Google App Engine
This is Rietveld