Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous. (Closed)

Created:
Feb. 28, 2017, 12:03 p.m. by sergei
Modified:
March 20, 2017, 12:21 p.m.
Reviewers:
Oleksandr
CC:
anton, Felix Dahlke, Eric
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebase and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -61 lines) Patch
M README.md View 1 chunk +4 lines, -1 line 0 comments Download
M include/AdblockPlus/FilterEngine.h View 1 3 chunks +34 lines, -8 lines 0 comments Download
M shell/src/Main.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/FilterEngine.cpp View 1 3 chunks +76 lines, -30 lines 0 comments Download
M test/FilterEngine.cpp View 1 6 chunks +7 lines, -9 lines 0 comments Download
M test/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/Prefs.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/UpdateCheck.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/WebRequest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12
sergei
Feb. 28, 2017, 2:35 p.m. (2017-02-28 14:35:50 UTC) #1
Eric
I didn't read the rest of the code once I looked at the signature of ...
Feb. 28, 2017, 5:04 p.m. (2017-02-28 17:04:50 UTC) #2
sergei
https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h#newcode241 include/AdblockPlus/FilterEngine.h:241: static void CreateAsync(const JsEnginePtr& jsEngine, On 2017/02/28 17:04:50, Eric ...
Feb. 28, 2017, 10:18 p.m. (2017-02-28 22:18:27 UTC) #3
Eric
On 2017/02/28 22:18:27, sergei wrote: > Sorry, but what is the aim of this message? ...
Feb. 28, 2017, 11:06 p.m. (2017-02-28 23:06:12 UTC) #4
sergei
BTW, std::future does not have continuation "then" yet, so I would like to still keep ...
March 1, 2017, 7:19 a.m. (2017-03-01 07:19:13 UTC) #5
Eric
On 2017/03/01 07:19:13, sergei wrote: > BTW, std::future does not have continuation "then" yet If ...
March 1, 2017, 3:19 p.m. (2017-03-01 15:19:38 UTC) #6
sergei
On 2017/03/01 15:19:38, Eric wrote: > On 2017/03/01 07:19:13, sergei wrote: > > BTW, std::future ...
March 1, 2017, 3:22 p.m. (2017-03-01 15:22:52 UTC) #7
Eric
The API you're proposing, the one with a callback, enforces a single way of using ...
March 1, 2017, 3:44 p.m. (2017-03-01 15:44:20 UTC) #8
sergei
On 2017/03/01 15:44:20, Eric wrote: > The API you're proposing, the one with a callback, ...
March 16, 2017, 8:56 a.m. (2017-03-16 08:56:27 UTC) #9
Oleksandr
LGTM with the nit addressed. https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h#newcode219 include/AdblockPlus/FilterEngine.h:219: struct CreateParameters Nit: How ...
March 16, 2017, 3:05 p.m. (2017-03-16 15:05:25 UTC) #10
sergei
https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29377064/diff/29377560/include/AdblockPlus/FilterEngine.h#newcode219 include/AdblockPlus/FilterEngine.h:219: struct CreateParameters On 2017/03/16 15:05:25, Oleksandr wrote: > Nit: ...
March 16, 2017, 3:50 p.m. (2017-03-16 15:50:03 UTC) #11
sergei
March 17, 2017, 2:39 p.m. (2017-03-17 14:39:39 UTC) #12
I'm going to push it today.

Powered by Google App Engine
This is Rietveld