Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java

Issue 29453722: Noissue - Lint adjustments and optimizations (Closed)
Patch Set: Created June 1, 2017, 9:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java
===================================================================
--- a/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java
+++ b/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java
@@ -127,30 +127,30 @@ public class MoreBlockingPreferenceCateg
}
else
{
sb.append(this.getContext().getString(R.string.last_update_never));
}
cbp.setSummary(sb.toString());
}
- cbp.setTitle(this.getContext().getString(resInt.intValue()));
+ cbp.setTitle(this.getContext().getString(resInt));
cbp.setChecked(sub.isEnabled());
cbp.setPersistent(false);
cbp.setKey(sub.getId());
cbp.setOnPreferenceChangeListener(this);
this.addPreference(cbp);
}
}
}
}
@Override
public boolean onPreferenceChange(final Preference preference, final Object newValue)
{
final String id = preference.getKey();
- final boolean enabled = ((Boolean) newValue).booleanValue();
+ final boolean enabled = ((Boolean) newValue);
anton 2017/06/02 07:39:56 minor: double brackets are not required, it could
diegocarloslima 2017/06/02 21:03:41 Acknowledged.
this.engine.changeSubscriptionState(id, enabled);
return true;
}
}

Powered by Google App Engine
This is Rietveld