Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1892)

Issue 29512648: Issue 5475 - Update adblockpluscore dependency to revision hg:b935a0402215 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by sergei
Modified:
2 months ago
Reviewers:
hub
CC:
Felix Dahlke, Eric, Oleksandr
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -344 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M include/AdblockPlus/FilterEngine.h View 2 chunks +3 lines, -0 lines 2 comments Download
M include/AdblockPlus/IFileSystem.h View 4 chunks +11 lines, -30 lines 1 comment Download
M include/AdblockPlus/Notification.h View 1 chunk +1 line, -0 lines 1 comment Download
M lib/api.js View 2 chunks +2 lines, -1 line 1 comment Download
M lib/compat.js View 3 chunks +14 lines, -91 lines 3 comments Download
M lib/io.js View 1 chunk +64 lines, -43 lines 0 comments Download
M lib/prefs.js View 4 chunks +3 lines, -5 lines 2 comments Download
M lib/updater.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/utils.js View 2 chunks +0 lines, -8 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +2 lines, -1 line 1 comment Download
M src/DefaultFileSystem.h View 2 chunks +13 lines, -12 lines 0 comments Download
M src/DefaultFileSystem.cpp View 8 chunks +23 lines, -35 lines 0 comments Download
M src/FileSystemJsObject.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M src/FilterEngine.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/Notification.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M test/BaseJsTest.h View 3 chunks +16 lines, -27 lines 0 comments Download
M test/DefaultFileSystem.cpp View 11 chunks +11 lines, -15 lines 0 comments Download
M test/FileSystemJsObject.cpp View 4 chunks +21 lines, -36 lines 0 comments Download
M test/FilterEngine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M test/Prefs.cpp View 5 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 3
sergei
https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus/FilterEngine.h#newcode54 include/AdblockPlus/FilterEngine.h:54: TYPE_TYPE_ELEMHIDE_EMULATION, Meanwhile I have merely added this filter type ...
2 months, 1 week ago (2017-08-11 12:49:39 UTC) #1
sergei
https://codereview.adblockplus.org/29512648/diff/29512649/libadblockplus.gyp File libadblockplus.gyp (right): https://codereview.adblockplus.org/29512648/diff/29512649/libadblockplus.gyp#newcode136 libadblockplus.gyp:136: 'lib/init.js', BTW, the core now has RSA (git 56fcfd105b9e09d308dd8953bd9ef3ad0ef9d113), ...
2 months, 1 week ago (2017-08-11 14:43:11 UTC) #2
hub
2 months, 1 week ago (2017-08-11 14:52:59 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5