Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29523647: Issue 5555 - [webextensions] Add a message for Firefox users on the options page (Closed)

Created:
Aug. 22, 2017, 12:02 p.m. by Wladimir Palant
Modified:
Aug. 23, 2017, 3:07 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 5555 - [webextensions] Add a message for Firefox users on the options page

Patch Set 1 #

Total comments: 7

Patch Set 2 : Reordered CSS properties and made the link open in new tab #

Patch Set 3 : Adjusted wording as suggested by Lisa #

Total comments: 2

Patch Set 4 : Adjusted message again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M options.html View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M options.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
Aug. 22, 2017, 12:02 p.m. (2017-08-22 12:02:50 UTC) #1
Sebastian Noack
LGTM. But strictly speaking this code while in adblockpluschrome, is part of the UI module, ...
Aug. 22, 2017, 12:08 p.m. (2017-08-22 12:08:00 UTC) #2
Thomas Greiner
Thanks for looping me in. I mentioned a couple of things we could tackle but ...
Aug. 22, 2017, 5:13 p.m. (2017-08-22 17:13:26 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29523647/diff/29523648/options.html File options.html (right): https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcode58 options.html:58: font-size: 120%; On 2017/08/22 17:13:25, Thomas Greiner wrote: > ...
Aug. 22, 2017, 6:44 p.m. (2017-08-22 18:44:07 UTC) #4
hub
https://codereview.adblockplus.org/29523647/diff/29523743/options.html File options.html (right): https://codereview.adblockplus.org/29523647/diff/29523743/options.html#newcode159 options.html:159: <a href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension" target="_blank">​We neither</a>. Lisa wrote "Neither do we." ...
Aug. 23, 2017, 12:45 p.m. (2017-08-23 12:45:53 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29523647/diff/29523743/options.html File options.html (right): https://codereview.adblockplus.org/29523647/diff/29523743/options.html#newcode159 options.html:159: <a href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension" target="_blank">​We neither</a>. On 2017/08/23 12:45:52, hub wrote: ...
Aug. 23, 2017, 1:30 p.m. (2017-08-23 13:30:46 UTC) #6
saroyanm
Aug. 23, 2017, 2:56 p.m. (2017-08-23 14:56:42 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld