Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29524565: Issue 5556 - remove LogSystem setters (Closed)

Created:
Aug. 23, 2017, 11:45 a.m. by sergei
Modified:
Aug. 29, 2017, 10:30 a.m.
Reviewers:
diegocarloslima, anton, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Messages

Total messages: 10
sergei
Aug. 23, 2017, 11:51 a.m. (2017-08-23 11:51:09 UTC) #1
anton
On 2017/08/23 11:51:09, sergei wrote: Please add it depends on https://codereview.adblockplus.org/29523679/ and https://codereview.adblockplus.org/29523682/
Aug. 24, 2017, 11:07 a.m. (2017-08-24 11:07:46 UTC) #2
sergei
On 2017/08/24 11:07:46, anton wrote: > On 2017/08/23 11:51:09, sergei wrote: > > Please add ...
Aug. 24, 2017, 11:09 a.m. (2017-08-24 11:09:23 UTC) #3
anton
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java (right): https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java#newcode45 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45: return null; comment like "returning null log system make ...
Aug. 24, 2017, 11:12 a.m. (2017-08-24 11:12:50 UTC) #4
anton
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java (left): https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java#oldcode38 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:38: jsEngine.setDefaultLogSystem(); as far as i can see passing `null` ...
Aug. 24, 2017, 11:23 a.m. (2017-08-24 11:23:45 UTC) #5
sergei
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java (left): https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java#oldcode38 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:38: jsEngine.setDefaultLogSystem(); On 2017/08/24 11:23:44, anton wrote: > as far ...
Aug. 24, 2017, 11:38 a.m. (2017-08-24 11:38:26 UTC) #6
anton
On 2017/08/24 11:38:26, sergei wrote: > https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java > File > libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java > (left): > > ...
Aug. 24, 2017, 11:39 a.m. (2017-08-24 11:39:28 UTC) #7
sergei
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java (right): https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java#newcode45 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45: return null; On 2017/08/24 11:12:50, anton wrote: > comment ...
Aug. 24, 2017, 1:39 p.m. (2017-08-24 13:39:10 UTC) #8
anton
On 2017/08/24 13:39:10, sergei wrote: > https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java > File > libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java > (right): > > ...
Aug. 24, 2017, 2:02 p.m. (2017-08-24 14:02:42 UTC) #9
diegocarloslima
Aug. 28, 2017, 9:09 p.m. (2017-08-28 21:09:46 UTC) #10
On 2017/08/24 14:02:42, anton wrote:
> On 2017/08/24 13:39:10, sergei wrote:
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > File
> >
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> >
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45:
> > return null;
> > On 2017/08/24 11:12:50, anton wrote:
> > > comment like "returning null log system make JsEngine using default log
> system
> > > impl" is needed
> > 
> > Done.
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:40:
> > this(appInfo, /* logSystem */null);
> > On 2017/08/24 11:12:50, anton wrote:
> > > please remove comment
> > 
> > Done.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld