Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 29530598: Issue 5588 - Explicitly clear badge text on tab update (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Manish Jethani
Modified:
2 years, 5 months ago
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5588 - Explicitly clear badge text on tab update Chrome automatically clears the browser action badge text when the URL of the tab is updated, but Firefox doesn't.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add link to Firefox bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M lib/stats.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Manish Jethani
2 years, 5 months ago (2017-08-29 20:48:06 UTC) #1
Manish Jethani
Patch Set 1
2 years, 5 months ago (2017-08-29 20:49:03 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js#newcode38 lib/stats.js:38: // the tab is updated, but Firefox doesn't. Please ...
2 years, 5 months ago (2017-08-29 23:07:01 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js#newcode38 lib/stats.js:38: // the tab is updated, but Firefox doesn't. On ...
2 years, 5 months ago (2017-08-30 08:13:30 UTC) #4
Manish Jethani
On 2017/08/30 08:13:30, Wladimir Palant wrote: > https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js > File lib/stats.js (right): > > https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js#newcode38 ...
2 years, 5 months ago (2017-08-30 10:29:16 UTC) #5
Manish Jethani
Patch Set 2: Add link to Firefox bug https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29530598/diff/29530599/lib/stats.js#newcode38 lib/stats.js:38: // ...
2 years, 5 months ago (2017-08-30 10:30:35 UTC) #6
Wladimir Palant
LGTM We'll need to make sure that this doesn't reset the badge after it already ...
2 years, 5 months ago (2017-08-30 13:00:35 UTC) #7
Wladimir Palant
On 2017/08/30 10:29:16, Manish Jethani wrote: > They may not consider this to be a ...
2 years, 5 months ago (2017-08-30 13:02:08 UTC) #8
Sebastian Noack
2 years, 5 months ago (2017-08-30 16:56:28 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5