Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 29535572: Issue 5183 - make FileSystemPtr std::unique_ptr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by sergei
Modified:
2 years, 1 month ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29535562/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M include/AdblockPlus/IFileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/BaseJsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/FileSystemJsObject.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M test/Prefs.cpp View 6 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 2
sergei
2 years, 1 month ago (2017-09-04 10:00:31 UTC) #1
hub
2 years, 1 month ago (2017-09-05 13:37:14 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5