libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java - Issue 29536601: Noissue - update expected values in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

Issue 29536601: Noissue - update expected values in tests (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Sept. 5, 2017, 12:25 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

index 66c245f2218c4e1505805d6772384b9b68131cfd..4fcb6f4aae67b819193cd5ca02d2113b6729e591 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java

@@ -54,8 +54,8 @@ public class AppInfoJsObjectTest extends BaseJsTest

.build();

JsEngine jsEngine = new JsEngine(appInfo);

- assertEquals("0", jsEngine.evaluate("_appInfo.version").asString());

- assertEquals("adblockplusandroid", jsEngine.evaluate("_appInfo.name").asString());

+ assertEquals("1.0", jsEngine.evaluate("_appInfo.version").asString());

+ assertEquals("libadblockplus-android", jsEngine.evaluate("_appInfo.name").asString());

sergei 2017/09/05 12:27:17 One can find the default values which are used in

assertEquals("android", jsEngine.evaluate("_appInfo.application").asString());

assertEquals("0", jsEngine.evaluate("_appInfo.applicationVersion").asString());

assertEquals("en_US", jsEngine.evaluate("_appInfo.locale").asString());

« no previous file with comments | « no previous file | no next file » | no next file with comments »