Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 29556775: Issue 5518 - Add Ecosia as secondary search engine (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by diegocarloslima
Modified:
2 years, 4 months ago
Reviewers:
anton, jens
CC:
René Jeschke, Felix Dahlke
Visibility:
Public.

Description

Issue 5518 - Add Ecosia as secondary search engine

Patch Set 1 #

Patch Set 2 : Including requested changes for ecosia search plugin xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mozharness/abb/ecosia.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mozharness/abb/transform_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
diegocarloslima
This change is required to avoid 'Not enough arguments for format string' error when performing ...
2 years, 5 months ago (2017-09-26 23:14:50 UTC) #1
anton
On 2017/09/26 23:14:50, diegocarloslima wrote: > This change is required to avoid 'Not enough arguments ...
2 years, 5 months ago (2017-09-28 11:26:51 UTC) #2
jens
2 years, 4 months ago (2017-09-29 15:20:33 UTC) #3
On 2017/09/28 11:26:51, anton wrote:
> On 2017/09/26 23:14:50, diegocarloslima wrote:
> > This change is required to avoid 'Not enough arguments for format string'
> error
> > when performing multi-locale builds
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5