Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

Issue 29567743: Issue 5835 - Add some notification related message handlers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by kzar
Modified:
2 years, 8 months ago
Reviewers:
Thomas Greiner
CC:
Manish Jethani, Sebastian Noack
Visibility:
Public.

Description

Issue 5835 - Add some notification related message handlers Depends on this review: https://codereview.adblockplus.org/29567746/

Patch Set 1 #

Patch Set 2 : Updated to match the new issue description #

Total comments: 4

Patch Set 3 : Addressed Sebastian's feedback #

Total comments: 4

Patch Set 4 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M background.js View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M messageResponder.js View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8
kzar
Patch Set 1
2 years, 8 months ago (2017-10-06 13:02:27 UTC) #1
kzar
Patch Set 2 : Updated to match the new issue description
2 years, 8 months ago (2017-10-06 20:08:34 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29567743/diff/29567850/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29567743/diff/29567850/messageResponder.js#newcode31 messageResponder.js:31: const {getActiveNotification, shouldDisplay} = require("notificationHelper"); You have to implement ...
2 years, 8 months ago (2017-10-08 01:35:35 UTC) #3
kzar
Patch Set 3 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29567743/diff/29567850/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29567743/diff/29567850/messageResponder.js#newcode31 messageResponder.js:31: const {getActiveNotification, ...
2 years, 8 months ago (2017-10-08 10:08:16 UTC) #4
Sebastian Noack
That looks better. I put myself back to CC, since this is Thomas his module.
2 years, 8 months ago (2017-10-08 19:12:36 UTC) #5
Thomas Greiner
https://codereview.adblockplus.org/29567743/diff/29569555/background.js File background.js (right): https://codereview.adblockplus.org/29567743/diff/29569555/background.js#newcode145 background.js:145: shouldDisplay() { return true; } Coding style: "Opening braces ...
2 years, 8 months ago (2017-10-09 10:52:59 UTC) #6
kzar
Patch Set 4 : Addressed nits https://codereview.adblockplus.org/29567743/diff/29569555/background.js File background.js (right): https://codereview.adblockplus.org/29567743/diff/29569555/background.js#newcode145 background.js:145: shouldDisplay() { return ...
2 years, 8 months ago (2017-10-09 11:13:51 UTC) #7
Thomas Greiner
2 years, 8 months ago (2017-10-09 12:39:33 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5