Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(385)

Issue 29573041: Issue 5850 - Social media links are broken (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by saroyanm
Modified:
2 years, 4 months ago
Reviewers:
ire
Visibility:
Public.

Description

Issue 5850 - Social media links are broken

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M desktop-options.html View 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 2
saroyanm
Ire can you please have a look, It's a small one. https://codereview.adblockplus.org/29573041/diff/29573042/desktop-options.html File desktop-options.html (right): ...
2 years, 4 months ago (2017-10-10 20:15:11 UTC) #1
ire
2 years, 4 months ago (2017-10-11 09:18:34 UTC) #2
LGTM

https://codereview.adblockplus.org/29573041/diff/29573042/desktop-options.html
File desktop-options.html (right):

https://codereview.adblockplus.org/29573041/diff/29573042/desktop-options.htm...
desktop-options.html:312: <li><a id="twitter" target="_blank">Twitter</a></li>
On 2017/10/10 20:15:10, saroyanm wrote:
> I decided to use target="_blank" instead of target="_top" to be consistent
with
> all other links on the page.

Ack. I think this was the right decision.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5