Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29581937: Noissue - Use anonymous blocks instead of anonymous functions (Closed)

Created:
Oct. 18, 2017, 2:10 a.m. by Manish Jethani
Modified:
Oct. 18, 2017, 10:54 a.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Use anonymous blocks instead of anonymous functions

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M ext/background.js View 2 chunks +1 line, -2 lines 0 comments Download
M ext/common.js View 2 chunks +1 line, -2 lines 0 comments Download
M ext/content.js View 2 chunks +1 line, -2 lines 0 comments Download
M ext/devtools.js View 1 chunk +1 line, -2 lines 0 comments Download
M qunit/tests/cssEscaping.js View 2 chunks +1 line, -2 lines 0 comments Download
M qunit/tests/filterValidation.js View 2 chunks +1 line, -2 lines 0 comments Download
M qunit/tests/prefs.js View 2 chunks +1 line, -2 lines 0 comments Download
M qunit/tests/url.js View 2 chunks +1 line, -2 lines 0 comments Download
M qunit/tests/versionComparator.js View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Oct. 18, 2017, 2:10 a.m. (2017-10-18 02:10:55 UTC) #1
Manish Jethani
Patch Set 1 I just realized we can do this all over the place.
Oct. 18, 2017, 2:12 a.m. (2017-10-18 02:12:20 UTC) #2
Sebastian Noack
Oct. 18, 2017, 3:45 a.m. (2017-10-18 03:45:49 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld