Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 29586579: Issue 5902 - Add translations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by anton
Modified:
2 years ago
Reviewers:
diegocarloslima, jens
CC:
vicky, Felix Dahlke, sergei
Visibility:
Public.

Description

Issue 5902 - Add translations

Patch Set 1 #

Total comments: 7

Patch Set 2 : RTL changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -3 lines) Patch
M libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml View 1 1 chunk +1 line, -1 line 0 comments Download
A libadblockplus-android-settings/res/values-ar/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-de/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-el/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-es-rUS/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-es/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-fa/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-hi/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-hu/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-in/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-it/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ja/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ko/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-pl/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-pt-rBR/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-pt/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ro/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-th/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-tr/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-uk/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-vi/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-zh-rCN/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-zh-rTW/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
M libadblockplus-android-webviewapp/AndroidManifest.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
anton
2 years ago (2017-10-23 12:57:25 UTC) #1
diegocarloslima
On 2017/10/23 12:57:25, anton wrote: LGTM
2 years ago (2017-10-23 13:23:38 UTC) #2
sergei
Just a couple of notes, I think we should review the glossary, at least it ...
2 years ago (2017-10-23 13:42:27 UTC) #3
anton
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml File libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml#newcode8 libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:8: <string name="fragment_adblock_settings_aa_enabled_summary">Мы хотели бы призывать веб-сайты использовать прямую, неинтрузивную ...
2 years ago (2017-10-23 13:47:50 UTC) #4
jens
2 years ago (2017-10-24 10:13:38 UTC) #5
On 2017/10/23 13:47:50, anton wrote:
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:8:
> <string name="fragment_adblock_settings_aa_enabled_summary">Мы хотели бы
> призывать веб-сайты использовать прямую, неинтрузивную рекламу. Вот почему мы
> установили строгие правила для определения Допустимой рекламы, которые
> отображаются в настройках по умолчанию. Если вы хотите просматривать сайты без
> рекламы, вы можете отключить эту настройку в любое время.</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > Did we decided to not use the term "неинтрузивную"?
> 
> There was no final decision afaik.
> We tend to agree (including me) that translate agency was wrong but we should
> ask for their explanation first. Also it's consistent
> with our other products (ABB/Android) and Google play description, so we will
> have to change it everywhere we use it.
> 
> I'd prefer to do it in separate task/commit.
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:10:
> <string name="fragment_adblock_settings_wl_summary">Добавьте сайты, на которых
> вы хотите видеть рекламу к этому списку.</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > I would at least remove "к этому списку".
> > We are not injecting any ad, we are proving a means for blocking and
> > whitelisting based on subscriptions, and the blocked things are not
> necessarily
> > only ad, it's totally up to a user selection of subscriptions. I think it
> should
> > be rather something like
> > "Отключено на следующих сайтах" but that variant can sound conflicting with
> > "Разрешенные домены", so one should think about it.
> 
> Can you initiate that discussion with Tamara, please. It's not so obvious as
in
> "неинтрузивная" case.
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:14:
> <string
>
name="fragment_adblock_settings_allowed_connection_type_wifi_non_metered">Неизмеряемые
> сети Wi-Fi</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > I would translate it differently, not sure how exactly but differently, e.g.
> > immediate candidates are "Wi-Fi без учета трафика" or "Wi-Fi с бесплатным
> > трафиком", how is it actually translated in Android?
> 
> Should be discussed too. As for me it's not so obvious too.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5