Issue 5902 - Add translations

Issue 5902 - Add translations

[diegocarloslima, 2017-10-23 13:23:38]

On 2017/10/23 12:57:25, anton wrote:

LGTM

[sergei, 2017-10-23 13:42:27]

Just a couple of notes, I think we should review the glossary, at least it looks
inconsistent from what we had a couple of year ago and what is in other
products.

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
File libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:7:
<string name="fragment_adblock_settings_aa_enabled_title">Допустимая
реклама</string>
I think there was a document with the terms and AA in Ru is called differently
there.

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:8:
<string name="fragment_adblock_settings_aa_enabled_summary">Мы хотели бы
призывать веб-сайты использовать прямую, неинтрузивную рекламу. Вот почему мы
установили строгие правила для определения Допустимой рекламы, которые
отображаются в настройках по умолчанию. Если вы хотите просматривать сайты без
рекламы, вы можете отключить эту настройку в любое время.</string>
Did we decided to not use the term "неинтрузивную"?

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:10:
<string name="fragment_adblock_settings_wl_summary">Добавьте сайты, на которых
вы хотите видеть рекламу к этому списку.</string>
I would at least remove "к этому списку".
We are not injecting any ad, we are proving a means for blocking and
whitelisting based on subscriptions, and the blocked things are not necessarily
only ad, it's totally up to a user selection of subscriptions. I think it should
be rather something like
"Отключено на следующих сайтах" but that variant can sound conflicting with
"Разрешенные домены", so one should think about it.

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:14:
<string
name="fragment_adblock_settings_allowed_connection_type_wifi_non_metered">Неизмеряемые
сети Wi-Fi</string>
I would translate it differently, not sure how exactly but differently, e.g.
immediate candidates are "Wi-Fi без учета трафика" or "Wi-Fi с бесплатным
трафиком", how is it actually translated in Android?

[anton, 2017-10-23 13:47:50]

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
File libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:8:
<string name="fragment_adblock_settings_aa_enabled_summary">Мы хотели бы
призывать веб-сайты использовать прямую, неинтрузивную рекламу. Вот почему мы
установили строгие правила для определения Допустимой рекламы, которые
отображаются в настройках по умолчанию. Если вы хотите просматривать сайты без
рекламы, вы можете отключить эту настройку в любое время.</string>
On 2017/10/23 13:42:26, sergei wrote:
> Did we decided to not use the term "неинтрузивную"?

There was no final decision afaik.
We tend to agree (including me) that translate agency was wrong but we should
ask for their explanation first. Also it's consistent
with our other products (ABB/Android) and Google play description, so we will
have to change it everywhere we use it.

I'd prefer to do it in separate task/commit.

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:10:
<string name="fragment_adblock_settings_wl_summary">Добавьте сайты, на которых
вы хотите видеть рекламу к этому списку.</string>
On 2017/10/23 13:42:26, sergei wrote:
> I would at least remove "к этому списку".
> We are not injecting any ad, we are proving a means for blocking and
> whitelisting based on subscriptions, and the blocked things are not
necessarily
> only ad, it's totally up to a user selection of subscriptions. I think it
should
> be rather something like
> "Отключено на следующих сайтах" but that variant can sound conflicting with
> "Разрешенные домены", so one should think about it.

Can you initiate that discussion with Tamara, please. It's not so obvious as in
"неинтрузивная" case.

https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:14:
<string
name="fragment_adblock_settings_allowed_connection_type_wifi_non_metered">Неизмеряемые
сети Wi-Fi</string>
On 2017/10/23 13:42:26, sergei wrote:
> I would translate it differently, not sure how exactly but differently, e.g.
> immediate candidates are "Wi-Fi без учета трафика" or "Wi-Fi с бесплатным
> трафиком", how is it actually translated in Android?

Should be discussed too. As for me it's not so obvious too.

[jens, 2017-10-24 10:13:38]

On 2017/10/23 13:47:50, anton wrote:
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:8:
> <string name="fragment_adblock_settings_aa_enabled_summary">Мы хотели бы
> призывать веб-сайты использовать прямую, неинтрузивную рекламу. Вот почему мы
> установили строгие правила для определения Допустимой рекламы, которые
> отображаются в настройках по умолчанию. Если вы хотите просматривать сайты без
> рекламы, вы можете отключить эту настройку в любое время.</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > Did we decided to not use the term "неинтрузивную"?
> 
> There was no final decision afaik.
> We tend to agree (including me) that translate agency was wrong but we should
> ask for their explanation first. Also it's consistent
> with our other products (ABB/Android) and Google play description, so we will
> have to change it everywhere we use it.
> 
> I'd prefer to do it in separate task/commit.
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:10:
> <string name="fragment_adblock_settings_wl_summary">Добавьте сайты, на которых
> вы хотите видеть рекламу к этому списку.</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > I would at least remove "к этому списку".
> > We are not injecting any ad, we are proving a means for blocking and
> > whitelisting based on subscriptions, and the blocked things are not
> necessarily
> > only ad, it's totally up to a user selection of subscriptions. I think it
> should
> > be rather something like
> > "Отключено на следующих сайтах" but that variant can sound conflicting with
> > "Разрешенные домены", so one should think about it.
> 
> Can you initiate that discussion with Tamara, please. It's not so obvious as
in
> "неинтрузивная" case.
> 
>
https://codereview.adblockplus.org/29586579/diff/29586580/libadblockplus-andr...
> libadblockplus-android-settings/res/values-ru/adblock_settings_strings.xml:14:
> <string
>
name="fragment_adblock_settings_allowed_connection_type_wifi_non_metered">Неизмеряемые
> сети Wi-Fi</string>
> On 2017/10/23 13:42:26, sergei wrote:
> > I would translate it differently, not sure how exactly but differently, e.g.
> > immediate candidates are "Wi-Fi без учета трафика" or "Wi-Fi с бесплатным
> > трафиком", how is it actually translated in Android?
> 
> Should be discussed too. As for me it's not so obvious too.

LGTM