Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29589555: Issue 5915 - adblockpluschrome won't build under Windows (Closed)

Created:
Oct. 26, 2017, 9:03 a.m. by Oleksandr
Modified:
Oct. 27, 2017, 12:12 p.m.
Visibility:
Public.

Description

Issue 5915 - adblockpluschrome won't build under Windows

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webpack_runner.js View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4
Oleksandr
https://codereview.adblockplus.org/29589555/diff/29589556/webpack_runner.js File webpack_runner.js (right): https://codereview.adblockplus.org/29589555/diff/29589556/webpack_runner.js#newcode59 webpack_runner.js:59: path: path.resolve(""), This means "current working directory".
Oct. 26, 2017, 9:08 a.m. (2017-10-26 09:08:42 UTC) #1
Wladimir Palant
LGTM
Oct. 26, 2017, 9:23 a.m. (2017-10-26 09:23:23 UTC) #2
kzar
LGTM
Oct. 26, 2017, 10:12 a.m. (2017-10-26 10:12:04 UTC) #3
tlucas
Oct. 26, 2017, 1:34 p.m. (2017-10-26 13:34:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld