Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29589561: Issue 5916 - Locale strings are broken in adblockpluschrome when building from Windows (Closed)

Created:
Oct. 26, 2017, 9:12 a.m. by Oleksandr
Modified:
Oct. 27, 2017, 12:12 p.m.
Visibility:
Public.

Description

Issue 5916 - Locale strings are broken in adblockpluschrome when building from Windows

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M packagerChrome.py View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 4
Oleksandr
https://codereview.adblockplus.org/29589561/diff/29589562/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29589561/diff/29589562/packagerChrome.py#newcode218 packagerChrome.py:218: targetFile = posixpath.join('_locales', locale, 'messages.json') A more generic approach ...
Oct. 26, 2017, 9:16 a.m. (2017-10-26 09:16:02 UTC) #1
Wladimir Palant
LGTM https://codereview.adblockplus.org/29589561/diff/29589562/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29589561/diff/29589562/packagerChrome.py#newcode218 packagerChrome.py:218: targetFile = posixpath.join('_locales', locale, 'messages.json') On 2017/10/26 09:16:02, ...
Oct. 26, 2017, 9:22 a.m. (2017-10-26 09:22:13 UTC) #2
kzar
LGTM
Oct. 26, 2017, 10:45 a.m. (2017-10-26 10:45:32 UTC) #3
tlucas
Oct. 26, 2017, 1:34 p.m. (2017-10-26 13:34:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld