Issue 29589646: shouldWrapAPIs in polifills breaks ABP for Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29589646: shouldWrapAPIs in polifills breaks ABP for Edge (Closed)

Created:
Oct. 26, 2017, 4:30 p.m. by Oleksandr

Modified:
Oct. 27, 2017, 1:15 p.m.

Reviewers:
Sebastian Noack, Manish Jethani, kzar

Visibility:
Public.

Description

shouldWrapAPIs in polifills breaks ABP for Edge

Patch Set 1 #

Total comments: 2

Created: Oct. 26, 2017, 4:30 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	polyfill.js	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29589646/diff/29589647/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/29589646/diff/29589647/polyfill.js#newcode120 polyfill.js:120: return !(browser.storage.local.get([], () => {}) instanceof Promise); This will ...

Oct. 26, 2017, 5:11 p.m. (2017-10-26 17:11:25 UTC) #2

Manish Jethani

Also I would add "Issue 4579" to the commit message and change it to whatever ...

Oct. 27, 2017, 11:32 a.m. (2017-10-27 11:32:23 UTC) #4

Manish Jethani

On 2017/10/27 11:32:23, Manish Jethani wrote: > Also I would add "Issue 4579" to the ...

Oct. 27, 2017, 11:45 a.m. (2017-10-27 11:45:34 UTC) #5

Oleksandr

Oct. 27, 2017, 1:15 p.m. (2017-10-27 13:15:29 UTC) #6

https://codereview.adblockplus.org/29589646/diff/29589647/polyfill.js
File polyfill.js (right):

https://codereview.adblockplus.org/29589646/diff/29589647/polyfill.js#newcode120
polyfill.js:120: return !(browser.storage.local.get([], () => {}) instanceof
Promise);
On 2017/10/26 17:11:24, Sebastian Noack wrote:
> This will defeat the purpose of this check, since on Firefox no promise is
> returned if a callback is provided.
> 
> What is the behavior/issue on Microsoft Edge?

I am not sure what happened but as I test again now there is just an exception
which gets caught by the catch as expected. No need for this patch then, so I am
closing this. Sorry for the trouble!

Expand All Messages | Collapse All Messages