Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29599601: Issue 5998 - Update "how to disable AA on Firefox" on About - Adblockplus.org (Closed)

Created:
Nov. 6, 2017, 3:21 p.m. by ire
Modified:
Nov. 9, 2017, 10:05 a.m.
Reviewers:
juliandoucette, Lisa, ire
CC:
jeen, kai
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5998 - Update "how to disable AA on Firefox" on About - Adblockplus.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updatd wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pages/acceptable-ads.md View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
ire
Nov. 6, 2017, 3:21 p.m. (2017-11-06 15:21:08 UTC) #1
juliandoucette
LGTM if Jeen or Lisa is OK with this.
Nov. 6, 2017, 3:39 p.m. (2017-11-06 15:39:14 UTC) #2
ire
On 2017/11/06 15:39:14, juliandoucette wrote: > LGTM if Jeen or Lisa is OK with this. ...
Nov. 6, 2017, 5 p.m. (2017-11-06 17:00:57 UTC) #3
Lisa
For future changes like this, please refer to me or Tom for final wording. Thanks. ...
Nov. 6, 2017, 5:23 p.m. (2017-11-06 17:23:33 UTC) #4
ire
On 2017/11/06 17:23:33, Lisa wrote: > For future changes like this, please refer to me ...
Nov. 7, 2017, 7:12 a.m. (2017-11-07 07:12:48 UTC) #5
Lisa
Hi Ire, I've updated #5998 with the correct wording. Thank you!
Nov. 7, 2017, 4:28 p.m. (2017-11-07 16:28:02 UTC) #6
juliandoucette
Not LGTM (until the wording is updated)
Nov. 7, 2017, 5:09 p.m. (2017-11-07 17:09:14 UTC) #7
ire
Nov. 9, 2017, 7:51 a.m. (2017-11-09 07:51:05 UTC) #8
New patchset uploaded

Powered by Google App Engine
This is Rietveld