Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(718)

Issue 29606600: Issue 5146 - Implement DownloadableSubscription parsing in C++

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by hub
Modified:
2 days, 12 hours ago
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5146 - Implement DownloadableSubscription parsing in C++

Patch Set 1 #

Total comments: 7

Patch Set 2 : Added md5 checksum. Reorganized some code. #

Patch Set 3 : Now all test pass (almost unchanged). Addressed many issues. #

Patch Set 4 : Simplify the logic of Process() #

Patch Set 5 : Improved logic for Process() #

Patch Set 6 : Latest changes #

Patch Set 7 : Rebased #

Patch Set 8 : Fix the UTF-8 encoding used for MD5. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1419 lines, -92 lines) Patch
A compiled/Base64.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A compiled/Base64.cpp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M compiled/FilterNotifier.h View 2 chunks +6 lines, -0 lines 0 comments Download
A compiled/Md5.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A compiled/Md5.cpp View 1 2 3 4 5 6 7 1 chunk +347 lines, -0 lines 0 comments Download
M compiled/String.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M compiled/StringScanner.h View 1 chunk +6 lines, -0 lines 0 comments Download
M compiled/bindings/main.cpp View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M compiled/storage/FilterStorage.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M compiled/storage/FilterStorage.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.h View 1 2 3 4 2 chunks +29 lines, -1 line 0 comments Download
M compiled/subscription/DownloadableSubscription.cpp View 1 2 3 4 5 1 chunk +251 lines, -0 lines 0 comments Download
M compiled/subscription/Subscription.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M lib/synchronizer.js View 1 2 3 chunks +25 lines, -81 lines 0 comments Download
M meson.build View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/stub-modules/utils.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
A test/synchronizer.js View 1 2 1 chunk +576 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hub
1 month ago (2017-11-13 22:25:11 UTC) #1
hub
This is still a draft version of this patch. I stash it for now it ...
1 month ago (2017-11-13 22:27:15 UTC) #2
hub
The known issues. https://codereview.adblockplus.org/29606600/diff/29606601/compiled/filter/CommentFilter.cpp File compiled/filter/CommentFilter.cpp (right): https://codereview.adblockplus.org/29606600/diff/29606601/compiled/filter/CommentFilter.cpp#newcode25 compiled/filter/CommentFilter.cpp:25: bool foundColon = false; this is ...
1 month ago (2017-11-13 22:35:28 UTC) #3
hub
2 weeks, 2 days ago (2017-11-27 17:15:45 UTC) #4

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5