Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/devtools.js

Issue 29607566: Issue 6035 - Workaround missing browser.devtools.panels.openResource (Closed)
Patch Set: Created Nov. 14, 2017, 12:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 { 20 {
21 let inspectedTabId = browser.devtools.inspectedWindow.tabId; 21 let inspectedTabId = browser.devtools.inspectedWindow.tabId;
22 let port = browser.runtime.connect({name: "devtools-" + inspectedTabId}); 22 let port = browser.runtime.connect({name: "devtools-" + inspectedTabId});
23 23
24 ext.onMessage = port.onMessage; 24 ext.onMessage = port.onMessage;
25 ext.devtools = browser.devtools; 25 ext.devtools = browser.devtools;
26
27 // Firefox as of 57 does not yet implement browser.devtools.panels.openResouce
28 if (!("openResource" in ext.devtools.panels))
29 ext.devtools.panels.openResource = window.open.bind(window);
Wladimir Palant 2017/11/14 13:12:37 While this will do as a quick work-around, I'd rat
kzar 2017/11/14 15:17:04 Good idea, done but under a new review https://cod
26 } 30 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld