Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29608555: Issue 6035 - Only use openResource API when it's supported (Closed)

Created:
Nov. 14, 2017, 3:13 p.m. by kzar
Modified:
Nov. 14, 2017, 6:02 p.m.
Visibility:
Public.

Description

Issue 6035 - Only use openResource API when it's supported

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only listen for left click events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M devtools-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M devtools-panel.js View 1 1 chunk +10 lines, -5 lines 0 comments Download
M skin/devtools-panel.css View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1 (See discussion here https://codereview.adblockplus.org/29607566/diff/29607567/ext/devtools.js#newcode29 .)
Nov. 14, 2017, 3:15 p.m. (2017-11-14 15:15:26 UTC) #1
Wladimir Palant
LGTM
Nov. 14, 2017, 3:18 p.m. (2017-11-14 15:18:23 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29608555/diff/29608556/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29608555/diff/29608556/devtools-panel.js#newcode101 devtools-panel.js:101: event.preventDefault(); Wait, won't this handle middle-clicks as well in ...
Nov. 14, 2017, 3:22 p.m. (2017-11-14 15:22:40 UTC) #3
kzar
Patch Set 2 : Only listen for left click events https://codereview.adblockplus.org/29608555/diff/29608556/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29608555/diff/29608556/devtools-panel.js#newcode101 ...
Nov. 14, 2017, 3:33 p.m. (2017-11-14 15:33:43 UTC) #4
Wladimir Palant
Nov. 14, 2017, 3:53 p.m. (2017-11-14 15:53:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld