Issue 29607566: Issue 6035 - Workaround missing browser.devtools.panels.openResource

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29607566: Issue 6035 - Workaround missing browser.devtools.panels.openResource (Closed)

Created:
Nov. 14, 2017, 12:01 p.m. by kzar

Modified:
Nov. 14, 2017, 3:17 p.m.

Reviewers:
Wladimir Palant

CC:
Manish Jethani, Sebastian Noack

Visibility:
Public.

Description

Issue 6035 - Workaround missing browser.devtools.panels.openResource

Patch Set 1 #

Total comments: 2

Created: Nov. 14, 2017, 12:01 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	ext/devtools.js	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29607566/diff/29607567/ext/devtools.js File ext/devtools.js (right): https://codereview.adblockplus.org/29607566/diff/29607567/ext/devtools.js#newcode29 ext/devtools.js:29: ext.devtools.panels.openResource = window.open.bind(window); While this will do as a ...

Nov. 14, 2017, 1:12 p.m. (2017-11-14 13:12:38 UTC) #2

kzar

Nov. 14, 2017, 3:17 p.m. (2017-11-14 15:17:04 UTC) #3

https://codereview.adblockplus.org/29607566/diff/29607567/ext/devtools.js
File ext/devtools.js (right):

https://codereview.adblockplus.org/29607566/diff/29607567/ext/devtools.js#new...
ext/devtools.js:29: ext.devtools.panels.openResource = window.open.bind(window);
On 2017/11/14 13:12:37, Wladimir Palant wrote:
> While this will do as a quick work-around, I'd rather go with a solution that
> allows users to copy the link via context menu (yes, this has been requested
> already). How about we make that element an <a target="_blank"> and only do
> event.preventDefault() on a click if openResource() is available? This way
users
> should also be able to middle-click in both Chrome and Firefox if they want to
> open the resource in a tab instead of the source viewer.

Good idea, done but under a new review
https://codereview.adblockplus.org/29608555/ .

Expand All Messages | Collapse All Messages