Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1264)

Issue 29612656: Issue 6053 - Workaround window.close problem on Firefox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by kzar
Modified:
1 year, 8 months ago
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 6053 - Workaround window.close problem on Firefox

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M composer.js View 3 chunks +13 lines, -2 lines 1 comment Download

Messages

Total messages: 4
kzar
Patch Set 1 https://codereview.adblockplus.org/29612656/diff/29612657/composer.js File composer.js (right): https://codereview.adblockplus.org/29612656/diff/29612657/composer.js#newcode56 composer.js:56: function closeMe() Taken straight from adblockplusui/issue-reporter.js.
1 year, 8 months ago (2017-11-20 14:54:48 UTC) #1
Wladimir Palant
LGTM but I added Thomas to the list of reviewers - it's his module, and ...
1 year, 8 months ago (2017-11-20 18:32:07 UTC) #2
Thomas Greiner
Indeed, the same concern applies here (see https://codereview.adblockplus.org/29595588/#msg2) so it'd be interesting to hear your ...
1 year, 8 months ago (2017-11-20 18:44:00 UTC) #3
kzar
1 year, 8 months ago (2017-11-21 12:45:40 UTC) #4
On 2017/11/20 18:44:00, Thomas Greiner wrote:
> Indeed, the same concern applies here (see
> https://codereview.adblockplus.org/29595588/#msg2) so it'd be interesting to
> hear your opinion on that.
> 
> Otherwise, LGTM since we're already using it in the issue reporter.

Well my opinion is that the closeMe approach is easier to reason about, the
window closes itself and all the logic to do that is self contained this way. I
do see your argument however, and I agree that this is kind of messy compared to
just calling window.close. We have filed bugs with Mozilla though so hopefully I
can remove this workaround sometime soon.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5