Issue 29612656: Issue 6053 - Workaround window.close problem on Firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29612656: Issue 6053 - Workaround window.close problem on Firefox (Closed)

Created:
Nov. 20, 2017, 2:53 p.m. by kzar

Modified:
Nov. 21, 2017, 12:48 p.m.

Reviewers:
Thomas Greiner, Wladimir Palant

CC:
Sebastian Noack

Visibility:
Public.

Description

Issue 6053 - Workaround window.close problem on Firefox

Patch Set 1 #

Total comments: 1

Created: Nov. 20, 2017, 2:53 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	composer.js	View		3 chunks	+13 lines, -2 lines	1 comment ()	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

Patch Set 1 https://codereview.adblockplus.org/29612656/diff/29612657/composer.js File composer.js (right): https://codereview.adblockplus.org/29612656/diff/29612657/composer.js#newcode56 composer.js:56: function closeMe() Taken straight from adblockplusui/issue-reporter.js.

Nov. 20, 2017, 2:54 p.m. (2017-11-20 14:54:48 UTC) #1

Wladimir Palant

LGTM but I added Thomas to the list of reviewers - it's his module, and ...

Nov. 20, 2017, 6:32 p.m. (2017-11-20 18:32:07 UTC) #2

Thomas Greiner

Indeed, the same concern applies here (see https://codereview.adblockplus.org/29595588/#msg2) so it'd be interesting to hear your ...

Nov. 20, 2017, 6:44 p.m. (2017-11-20 18:44:00 UTC) #3

kzar

Nov. 21, 2017, 12:45 p.m. (2017-11-21 12:45:40 UTC) #4

On 2017/11/20 18:44:00, Thomas Greiner wrote:
> Indeed, the same concern applies here (see
> https://codereview.adblockplus.org/29595588/#msg2) so it'd be interesting to
> hear your opinion on that.
> 
> Otherwise, LGTM since we're already using it in the issue reporter.

Well my opinion is that the closeMe approach is easier to reason about, the
window closes itself and all the logic to do that is self contained this way. I
do see your argument however, and I agree that this is kind of messy compared to
just calling window.close. We have filed bugs with Mozilla though so hopefully I
can remove this workaround sometime soon.

Expand All Messages | Collapse All Messages