Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 29646555: Issue 6210 - Implement Subscription (Double-opt-in) template for newsletter

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks, 1 day ago by ire
Modified:
1 week ago
Visibility:
Public.

Description

Issue : https://gitlab.com/eyeo/web.adblockplus.org/issues/1 Specification : https://gitlab.com/eyeo/spec/merge_requests/110 ## Relevant documentation Subscription template : https://www.backclick.de/confluence/display/BC5EN/Subscription+template Subscription (Double-opt-in) : https://www.backclick.de/confluence/pages/viewpage.action?pageId=4751543 Database designer : https://www.backclick.de/confluence/display/BC5EN/The+database+designer COLLABORATOR=julian@adblockplus.org

Patch Set 1 #

Total comments: 7

Patch Set 2 : Update hgignore #

Total comments: 76

Patch Set 3 : Addressed comments #4 and #5 #

Patch Set 4 : Add comments to Backclick template #

Patch Set 5 : Update privacy policy link #

Total comments: 23

Patch Set 6 : Addressed comments #

Patch Set 7 : Update sender email #

Patch Set 8 : Testing backclick template changes #

Patch Set 9 : Add gulp task to inline css, update templates #

Patch Set 10 : Update confirmation and success texts #

Total comments: 43

Patch Set 11 : Addressed comments #15 #

Patch Set 12 : Remove eRobinson feature #

Patch Set 13 : Update with specification changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -0 lines) Patch
A .hgignore View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
A README.md View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
A gulpfile.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +104 lines, -0 lines 0 comments Download
A package.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +22 lines, -0 lines 0 comments Download
A src/scss/_content.scss View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +19 lines, -0 lines 0 comments Download
A src/scss/_form.scss View 1 2 3 4 5 6 7 8 9 10 1 chunk +56 lines, -0 lines 0 comments Download
A src/scss/_layout.scss View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +107 lines, -0 lines 0 comments Download
A src/scss/_vars.scss View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +23 lines, -0 lines 0 comments Download
A src/scss/main.scss View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -0 lines 0 comments Download
A src/templates/confirm-email.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +76 lines, -0 lines 0 comments Download
A src/templates/signup.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +100 lines, -0 lines 0 comments Download
A src/templates/subscription-confirmed-email.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 19
ire
4 weeks, 1 day ago (2017-12-21 11:25:54 UTC) #1
ire
@Manvel please take a look at this when you can. I've added some background information ...
4 weeks, 1 day ago (2017-12-21 11:51:24 UTC) #2
ire
https://codereview.adblockplus.org/29646555/diff/29646556/index.html File index.html (right): https://codereview.adblockplus.org/29646555/diff/29646556/index.html#newcode7 index.html:7: <link rel="stylesheet" type="text/css" href="css/main.min.css"> In the actual implementation, I ...
4 weeks, 1 day ago (2017-12-21 11:54:06 UTC) #3
saroyanm
Comments are ready. Some of my comments may or may not be relevant, because as ...
4 weeks, 1 day ago (2017-12-21 16:07:59 UTC) #4
juliandoucette
CC wspee @ire Here are my first impressions. @wspee saroyanm already added his first impressions. ...
4 weeks, 1 day ago (2017-12-21 22:06:53 UTC) #5
ire
Thanks Manvel & Julian! I've uploaded a new patch set and addressed your comments. I ...
4 weeks ago (2017-12-22 10:33:27 UTC) #6
ire
https://codereview.adblockplus.org/29646555/diff/29646566/index.html File index.html (right): https://codereview.adblockplus.org/29646555/diff/29646566/index.html#newcode33 index.html:33: <a href="https://adblockplus.org/en/privacy" target="_blank">Privacy Policy</a> On 2017/12/21 16:07:57, saroyanm wrote: ...
4 weeks ago (2017-12-22 11:46:28 UTC) #7
saroyanm
Besides of I would encourage to reject the service providers in future that do not ...
4 weeks ago (2017-12-22 12:26:11 UTC) #8
juliandoucette
Responses. Will be AFK for 30 and then review the latest patchset. https://codereview.adblockplus.org/29646555/diff/29646566/index.html File index.html ...
4 weeks ago (2017-12-22 13:32:24 UTC) #9
juliandoucette
Not LGTM Spec comparison and HTML/CSS review. https://codereview.adblockplus.org/29646555/diff/29647600/index.html File index.html (right): https://codereview.adblockplus.org/29646555/diff/29647600/index.html#newcode4 index.html:4: <!-- Website ...
4 weeks ago (2017-12-22 14:34:32 UTC) #10
ire
New patch. I still haven't figured out the issue with the form not sending https://codereview.adblockplus.org/29646555/diff/29647600/index.html ...
4 weeks ago (2017-12-22 16:29:38 UTC) #11
juliandoucette
Protected this review because it contains links to live preview.
4 weeks ago (2017-12-22 20:57:29 UTC) #12
juliandoucette
On 2017/12/22 20:57:29, juliandoucette wrote: > Protected this review because it contains links to live ...
4 weeks ago (2017-12-22 21:07:50 UTC) #13
ire
Hey Julian, it looks like I've gotten the template to work. I think the reason ...
2 weeks, 2 days ago (2018-01-03 11:18:54 UTC) #14
juliandoucette
@saroyanm do you want to stay on this review? @ire this is not a full ...
2 weeks, 2 days ago (2018-01-04 02:34:25 UTC) #15
ire
On 2018/01/04 02:34:25, juliandoucette wrote: > @ire this is not a full review. Generally, styles ...
2 weeks, 1 day ago (2018-01-04 11:14:44 UTC) #16
saroyanm
On 2018/01/04 02:34:25, juliandoucette wrote: > @saroyanm do you want to stay on this review? ...
2 weeks, 1 day ago (2018-01-04 12:12:30 UTC) #17
ire
https://codereview.adblockplus.org/29646555/diff/29655572/backclick.html File backclick.html (right): https://codereview.adblockplus.org/29646555/diff/29655572/backclick.html#newcode233 backclick.html:233: <!--ERROR:ROBINSON--> On 2018/01/04 11:14:37, ire wrote: > On 2018/01/04 ...
1 week, 4 days ago (2018-01-08 11:02:38 UTC) #18
ire
1 week ago (2018-01-12 13:20:09 UTC) #19
Updated with specification changes
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5