Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(695)

Issue 29660578: Gitlab #2 - Extend privacy policy for newsletter signup form (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by juliandoucette
Modified:
5 months, 2 weeks ago
Reviewers:
ire
CC:
wspee
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue : https://gitlab.com/eyeo/web.eyeo.com/issues/2 Spec : https://gitlab.com/eyeo/spec/merge_requests/109

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pages/privacy.html View 2 chunks +20 lines, -1 line 2 comments Download

Messages

Total messages: 6
juliandoucette
6 months, 1 week ago (2018-01-09 14:42:56 UTC) #1
juliandoucette
(I know I could have created a pull request on Gitlab. I was lazy / ...
6 months, 1 week ago (2018-01-09 14:44:53 UTC) #2
juliandoucette
@wspee is this review premature? I would LGTM + NITs the spec pull request. Except ...
6 months, 1 week ago (2018-01-09 14:51:13 UTC) #3
ire
On 2018/01/09 14:44:53, juliandoucette wrote: > (I know I could have created a pull request ...
6 months, 1 week ago (2018-01-10 09:58:53 UTC) #4
ire
Note: I also left a couple of comments on the spec PR. https://codereview.adblockplus.org/29660578/diff/29660579/pages/privacy.html File pages/privacy.html ...
6 months, 1 week ago (2018-01-10 09:59:31 UTC) #5
juliandoucette
6 months, 1 week ago (2018-01-11 12:56:10 UTC) #6
I'll update as soon as Judith approves your changes in the PR. Thank you!

https://codereview.adblockplus.org/29660578/diff/29660579/pages/privacy.html
File pages/privacy.html (right):

https://codereview.adblockplus.org/29660578/diff/29660579/pages/privacy.html#...
pages/privacy.html:138: <h3 id="newsletter">
On 2018/01/10 09:59:31, ire wrote:
> This should be an <h4>

Good catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5