Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(704)

Issue 29664601: Issue 6212 - Don't create reports for type "other" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by tlucas
Modified:
3 months, 1 week ago
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/sitescripts/file/cd6f20a3aede
Visibility:
Public.

Description

Issue 6212 - Don't create reports for type "other"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M sitescripts/reports/bin/mailDigests.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3
tlucas
Patch Set 1 * Removed the "other"-branch in reports generation
6 months, 1 week ago (2018-01-12 11:59:40 UTC) #1
Vasily Kuznetsov
On 2018/01/12 11:59:40, tlucas wrote: > Patch Set 1 > > * Removed the "other"-branch ...
6 months, 1 week ago (2018-01-12 19:51:54 UTC) #2
tlucas
5 months, 3 weeks ago (2018-01-26 15:56:28 UTC) #3
On 2018/01/12 19:51:54, Vasily Kuznetsov wrote:
> On 2018/01/12 11:59:40, tlucas wrote:
> > Patch Set 1
> > 
> > * Removed the "other"-branch in reports generation
> 
> Assuming you've tested it, LGTM.

This is actually quite hard to test, without any data. I guess i'll have to
reach out to somebody able to provide me some data, in order to test this
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5