Issue 6272 - Can't sync because of changes in android_tools

Issue 6272 - Can't sync because of changes in android_tools

Implemented in the simplest way: https://issues.adblockplus.org/ticket/6272#comment:1

To be updated to respect eyeo python code style.

[anton, 2018-01-16 09:00:53]

On 2018/01/16 07:46:08, anton wrote:

Uploaded patch set #2

[diegocarloslima, 2018-01-17 13:08:54]

https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
File third_party/libadblockplus_android/prepare_build_tools.py (right):

https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
third_party/libadblockplus_android/prepare_build_tools.py:85: sys.exit(1)
Some of the changes here could go in a refactoring NoIssue review, since they
adjust things that were already commited and not directly related to this issue.
I would only insist if we have other python files that should also be refactored
in order to be in compliance with our coding style. Then, it would make sense to
adjust them all in a single code review.

[anton, 2018-01-17 13:12:11]

https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
File third_party/libadblockplus_android/prepare_build_tools.py (right):

https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
third_party/libadblockplus_android/prepare_build_tools.py:85: sys.exit(1)
On 2018/01/17 13:08:53, diegocarloslima wrote:
> Some of the changes here could go in a refactoring NoIssue review, since they
> adjust things that were already commited and not directly related to this
issue.
> I would only insist if we have other python files that should also be
refactored
> in order to be in compliance with our coding style. Then, it would make sense
to
> adjust them all in a single code review.

I've created separate task for applying python code style:
https://issues.adblockplus.org/ticket/6273

[diegocarloslima, 2018-01-18 13:37:57]

On 2018/01/17 13:12:11, anton wrote:
>
https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
> File third_party/libadblockplus_android/prepare_build_tools.py (right):
> 
>
https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
> third_party/libadblockplus_android/prepare_build_tools.py:85: sys.exit(1)
> On 2018/01/17 13:08:53, diegocarloslima wrote:
> > Some of the changes here could go in a refactoring NoIssue review, since
they
> > adjust things that were already commited and not directly related to this
> issue.
> > I would only insist if we have other python files that should also be
> refactored
> > in order to be in compliance with our coding style. Then, it would make
sense
> to
> > adjust them all in a single code review.
> 
> I've created separate task for applying python code style:
> https://issues.adblockplus.org/ticket/6273

OK, LGTM then

[jens, 2018-01-18 13:57:55]

On 2018/01/18 13:37:57, diegocarloslima wrote:
> On 2018/01/17 13:12:11, anton wrote:
> >
>
https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
> > File third_party/libadblockplus_android/prepare_build_tools.py (right):
> > 
> >
>
https://codereview.adblockplus.org/29670562/diff/29670572/third_party/libadbl...
> > third_party/libadblockplus_android/prepare_build_tools.py:85: sys.exit(1)
> > On 2018/01/17 13:08:53, diegocarloslima wrote:
> > > Some of the changes here could go in a refactoring NoIssue review, since
> they
> > > adjust things that were already commited and not directly related to this
> > issue.
> > > I would only insist if we have other python files that should also be
> > refactored
> > > in order to be in compliance with our coding style. Then, it would make
> sense
> > to
> > > adjust them all in a single code review.
> > 
> > I've created separate task for applying python code style:
> > https://issues.adblockplus.org/ticket/6273
> 
> OK, LGTM then

LGTM