Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(389)

Issue 29670584: Issue 6277 - Subproc.py should wait for subprocess to finish (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by anton
Modified:
1 year, 12 months ago
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 6277 - Subproc.py should wait for subprocess to finish. Now waiting for subprocess to finish. Formatted with respect to eyeo python code style.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -56 lines) Patch
M third_party/libadblockplus/subproc.py View 1 chunk +30 lines, -28 lines 0 comments Download
M third_party/libadblockplus_android/subproc.py View 1 chunk +30 lines, -28 lines 0 comments Download

Messages

Total messages: 4
anton
2 years ago (2018-01-16 12:03:38 UTC) #1
diegocarloslima
On 2018/01/16 12:03:38, anton wrote: LGTM
1 year, 12 months ago (2018-01-18 12:28:10 UTC) #2
sergei
LGTM
1 year, 12 months ago (2018-01-18 13:25:20 UTC) #3
jens
1 year, 12 months ago (2018-01-18 13:25:40 UTC) #4
On 2018/01/18 12:28:10, diegocarloslima wrote:
> On 2018/01/16 12:03:38, anton wrote:
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5