Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29670584: Issue 6277 - Subproc.py should wait for subprocess to finish (Closed)

Created:
Jan. 16, 2018, 12:01 p.m. by anton
Modified:
Jan. 19, 2018, 6:17 a.m.
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 6277 - Subproc.py should wait for subprocess to finish. Now waiting for subprocess to finish. Formatted with respect to eyeo python code style.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -56 lines) Patch
M third_party/libadblockplus/subproc.py View 1 chunk +30 lines, -28 lines 0 comments Download
M third_party/libadblockplus_android/subproc.py View 1 chunk +30 lines, -28 lines 0 comments Download

Messages

Total messages: 4
anton
Jan. 16, 2018, 12:03 p.m. (2018-01-16 12:03:38 UTC) #1
diegocarloslima
On 2018/01/16 12:03:38, anton wrote: LGTM
Jan. 18, 2018, 12:28 p.m. (2018-01-18 12:28:10 UTC) #2
sergei
LGTM
Jan. 18, 2018, 1:25 p.m. (2018-01-18 13:25:20 UTC) #3
jens
Jan. 18, 2018, 1:25 p.m. (2018-01-18 13:25:40 UTC) #4
On 2018/01/18 12:28:10, diegocarloslima wrote:
> On 2018/01/16 12:03:38, anton wrote:
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld