Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1204)

Issue 29673565: Issue 6066 - Implement 'force update' functionality for subscriptions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by jens
Modified:
1 year, 5 months ago
Reviewers:
diegocarloslima, anton
Visibility:
Public.

Description

As I had no mockups or detailed specifications for this feature but there seems to be a significant amount of users asking for it, I've implemented it the way I think it's fine.

Patch Set 1 : #

Total comments: 11

Patch Set 2 : Fixed typos and line length #

Total comments: 10

Patch Set 3 : Fixes #

Total comments: 3

Messages

Total messages: 14
jens
https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java (right): https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode67 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java:67: private static final long MINIMAL_DOWNLOAD_INTERVAL = DateUtils.MINUTE_IN_MILLIS; I double-checked ...
1 year, 6 months ago (2018-01-18 13:49:40 UTC) #1
anton
https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode262 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:262: .setMessage(hasInternet ? i prefer long ?: to look like ...
1 year, 6 months ago (2018-01-19 10:53:03 UTC) #2
jens
https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java (right): https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java#newcode262 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java:262: .setMessage(hasInternet ? On 2018/01/19 10:53:02, anton wrote: > i ...
1 year, 6 months ago (2018-01-19 11:00:29 UTC) #3
jens
https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java (right): https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java#newcode112 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java:112: public void enqueueDownload(final URL url, final String id, final ...
1 year, 6 months ago (2018-01-19 11:00:47 UTC) #4
jens
On 2018/01/19 11:00:47, jens wrote: > https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java > File > adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java > (right): > > ...
1 year, 6 months ago (2018-01-19 11:02:55 UTC) #5
anton
On 2018/01/19 11:02:55, jens wrote: > On 2018/01/19 11:00:47, jens wrote: > > > https://codereview.adblockplus.org/29673565/diff/29673617/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java ...
1 year, 6 months ago (2018-01-19 11:06:36 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml File adblockplussbrowser/res/values/sysstrings.xml (right): https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml#newcode16 adblockplussbrowser/res/values/sysstrings.xml:16: <string name="key_update_subscriptions">force_update_subscriptions</string> Usually the value is the name without ...
1 year, 6 months ago (2018-01-19 13:59:00 UTC) #7
jens
https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml File adblockplussbrowser/res/values/sysstrings.xml (right): https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml#newcode16 adblockplussbrowser/res/values/sysstrings.xml:16: <string name="key_update_subscriptions">force_update_subscriptions</string> On 2018/01/19 13:59:00, diegocarloslima wrote: > Usually ...
1 year, 6 months ago (2018-01-19 14:32:56 UTC) #8
jens
On 2018/01/19 14:32:56, jens wrote: > https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml > File adblockplussbrowser/res/values/sysstrings.xml (right): > > https://codereview.adblockplus.org/29673565/diff/29674574/adblockplussbrowser/res/values/sysstrings.xml#newcode16 > ...
1 year, 5 months ago (2018-01-23 15:13:22 UTC) #9
jens
https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/res/values/strings.xml File adblockplussbrowser/res/values/strings.xml (right): https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/res/values/strings.xml#newcode58 adblockplussbrowser/res/values/strings.xml:58: <string name="check_your_connection">It looks like you are offline. Please check ...
1 year, 5 months ago (2018-01-23 15:13:29 UTC) #10
diegocarloslima
https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java (right): https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java#newcode50 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java:50: public static boolean canUseInternet(final Context serviceContext, final boolean acceptMetered) ...
1 year, 5 months ago (2018-01-23 17:37:17 UTC) #11
diegocarloslima
On 2018/01/23 17:37:17, diegocarloslima wrote: > https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java > File > adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java > (right): > > ...
1 year, 5 months ago (2018-01-23 17:38:18 UTC) #12
jens
On 2018/01/23 17:38:18, diegocarloslima wrote: > On 2018/01/23 17:37:17, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java ...
1 year, 5 months ago (2018-01-24 09:22:58 UTC) #13
jens
1 year, 5 months ago (2018-01-24 09:23:06 UTC) #14
https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser...
File
adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java
(right):

https://codereview.adblockplus.org/29673565/diff/29677714/adblockplussbrowser...
adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/util/ConnectivityUtils.java:50:
public static boolean canUseInternet(final Context serviceContext, final boolean
acceptMetered)
On 2018/01/23 17:37:16, diegocarloslima wrote:
> Small thing, to make it more generic I think that the Context param should be
> called only 'context' instead of 'serviceContext'

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5