Issue 6297 - Added update page translations

Issue 6297 - Added update page translations

[saroyanm, 2018-01-22 09:19:53]

Tamara can you please have a look and let me know if I can give a go.

I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to keep the
links in place.

[tamara, 2018-01-24 10:56:27]

On 2018/01/22 09:19:53, saroyanm wrote:
> Tamara can you please have a look and let me know if I can give a go.
> 
> I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to keep the
> links in place.

Hey Manvel,

Is there any reason why the string with "Version ####" is missing? Out of the
languages I've reviewed so far, none of them has that one.  :-/

[tamara, 2018-01-24 10:58:36]

On 2018/01/24 10:56:27, tamara wrote:
> On 2018/01/22 09:19:53, saroyanm wrote:
> > Tamara can you please have a look and let me know if I can give a go.
> > 
> > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to keep
the
> > links in place.
> 
> Hey Manvel,
> 
> Is there any reason why the string with "Version ####" is missing? Out of the
> languages I've reviewed so far, none of them has that one.  :-/

Also, the specific string we had only for German is missing in the code review
for that language. I guess that's normal in this case, no?

[saroyanm, 2018-01-24 11:57:23]

On 2018/01/24 10:56:27, tamara wrote:
> On 2018/01/22 09:19:53, saroyanm wrote:
> > Tamara can you please have a look and let me know if I can give a go.
> > 
> > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to keep
the
> > links in place.
> 
> Hey Manvel,
> 
> Is there any reason why the string with "Version ####" is missing? Out of the
> languages I've reviewed so far, none of them has that one.  :-/

Seems like it was removed, see comment in the review ->
https://codereview.adblockplus.org/29592569/diff/29596582/updates.html#newcode43

[saroyanm, 2018-01-24 11:58:40]

On 2018/01/24 10:58:36, tamara wrote:
> On 2018/01/24 10:56:27, tamara wrote:
> > On 2018/01/22 09:19:53, saroyanm wrote:
> > > Tamara can you please have a look and let me know if I can give a go.
> > > 
> > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to keep
> the
> > > links in place.
> > 
> > Hey Manvel,
> > 
> > Is there any reason why the string with "Version ####" is missing? Out of
the
> > languages I've reviewed so far, none of them has that one.  :-/
> 
> Also, the specific string we had only for German is missing in the code review
> for that language. I guess that's normal in this case, no?

I can't see that string in the specification, so either it was removed, or never
specified. @wspee?
https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md

[tamara, 2018-01-24 12:07:29]

On 2018/01/24 11:58:40, saroyanm wrote:
> On 2018/01/24 10:58:36, tamara wrote:
> > On 2018/01/24 10:56:27, tamara wrote:
> > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > Tamara can you please have a look and let me know if I can give a go.
> > > > 
> > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to
keep
> > the
> > > > links in place.
> > > 
> > > Hey Manvel,
> > > 
> > > Is there any reason why the string with "Version ####" is missing? Out of
> the
> > > languages I've reviewed so far, none of them has that one.  :-/
> > 
> > Also, the specific string we had only for German is missing in the code
review
> > for that language. I guess that's normal in this case, no?
> 
> I can't see that string in the specification, so either it was removed, or
never
> specified. @wspee?
> https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md

The one that says "Section 2: For German users"

[saroyanm, 2018-01-24 13:26:37]

On 2018/01/24 12:07:29, tamara wrote:
> On 2018/01/24 11:58:40, saroyanm wrote:
> > On 2018/01/24 10:58:36, tamara wrote:
> > > On 2018/01/24 10:56:27, tamara wrote:
> > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > Tamara can you please have a look and let me know if I can give a go.
> > > > > 
> > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to
> keep
> > > the
> > > > > links in place.
> > > > 
> > > > Hey Manvel,
> > > > 
> > > > Is there any reason why the string with "Version ####" is missing? Out
of
> > the
> > > > languages I've reviewed so far, none of them has that one.  :-/
> > > 
> > > Also, the specific string we had only for German is missing in the code
> review
> > > for that language. I guess that's normal in this case, no?
> > 
> > I can't see that string in the specification, so either it was removed, or
> never
> > specified. @wspee?
> > https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> 
> The one that says "Section 2: For German users"

Well spotted, I missed that one. New patch is uploaded.

[tamara, 2018-01-24 13:41:43]

On 2018/01/24 13:26:37, saroyanm wrote:
> On 2018/01/24 12:07:29, tamara wrote:
> > On 2018/01/24 11:58:40, saroyanm wrote:
> > > On 2018/01/24 10:58:36, tamara wrote:
> > > > On 2018/01/24 10:56:27, tamara wrote:
> > > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > > Tamara can you please have a look and let me know if I can give a
go.
> > > > > > 
> > > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order to
> > keep
> > > > the
> > > > > > links in place.
> > > > > 
> > > > > Hey Manvel,
> > > > > 
> > > > > Is there any reason why the string with "Version ####" is missing? Out
> of
> > > the
> > > > > languages I've reviewed so far, none of them has that one.  :-/
> > > > 
> > > > Also, the specific string we had only for German is missing in the code
> > review
> > > > for that language. I guess that's normal in this case, no?
> > > 
> > > I can't see that string in the specification, so either it was removed, or
> > never
> > > specified. @wspee?
> > > https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> > 
> > The one that says "Section 2: For German users"
> 
> Well spotted, I missed that one. New patch is uploaded.

All reviewed now!

LGTM

[tamara, 2018-01-29 18:28:09]

On 2018/01/24 13:41:43, tamara wrote:
> On 2018/01/24 13:26:37, saroyanm wrote:
> > On 2018/01/24 12:07:29, tamara wrote:
> > > On 2018/01/24 11:58:40, saroyanm wrote:
> > > > On 2018/01/24 10:58:36, tamara wrote:
> > > > > On 2018/01/24 10:56:27, tamara wrote:
> > > > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > > > Tamara can you please have a look and let me know if I can give a
> go.
> > > > > > > 
> > > > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in order
to
> > > keep
> > > > > the
> > > > > > > links in place.
> > > > > > 
> > > > > > Hey Manvel,
> > > > > > 
> > > > > > Is there any reason why the string with "Version ####" is missing?
Out
> > of
> > > > the
> > > > > > languages I've reviewed so far, none of them has that one.  :-/
> > > > > 
> > > > > Also, the specific string we had only for German is missing in the
code
> > > review
> > > > > for that language. I guess that's normal in this case, no?
> > > > 
> > > > I can't see that string in the specification, so either it was removed,
or
> > > never
> > > > specified. @wspee?
> > > > https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> > > 
> > > The one that says "Section 2: For German users"
> > 
> > Well spotted, I missed that one. New patch is uploaded.
> 
> All reviewed now!
> 
> LGTM

@Manvel  Just found out part of the text from one of the source strings was
removed (Check it out for yourself) and the code for the hyperlink moved to
affect different words. Unfortunately, no one told me and the translations still
have that part of the text with also the hyperlink tags.

I will fix them on Crowdin to make sure they are consistent with the English.

Sorry about this.

[saroyanm, 2018-01-30 12:24:54]

On 2018/01/29 18:28:09, tamara wrote:
> On 2018/01/24 13:41:43, tamara wrote:
> > On 2018/01/24 13:26:37, saroyanm wrote:
> > > On 2018/01/24 12:07:29, tamara wrote:
> > > > On 2018/01/24 11:58:40, saroyanm wrote:
> > > > > On 2018/01/24 10:58:36, tamara wrote:
> > > > > > On 2018/01/24 10:56:27, tamara wrote:
> > > > > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > > > > Tamara can you please have a look and let me know if I can give
a
> > go.
> > > > > > > > 
> > > > > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in
order
> to
> > > > keep
> > > > > > the
> > > > > > > > links in place.
> > > > > > > 
> > > > > > > Hey Manvel,
> > > > > > > 
> > > > > > > Is there any reason why the string with "Version ####" is missing?
> Out
> > > of
> > > > > the
> > > > > > > languages I've reviewed so far, none of them has that one.  :-/
> > > > > > 
> > > > > > Also, the specific string we had only for German is missing in the
> code
> > > > review
> > > > > > for that language. I guess that's normal in this case, no?
> > > > > 
> > > > > I can't see that string in the specification, so either it was
removed,
> or
> > > > never
> > > > > specified. @wspee?
> > > > >
https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> > > > 
> > > > The one that says "Section 2: For German users"
> > > 
> > > Well spotted, I missed that one. New patch is uploaded.
> > 
> > All reviewed now!
> > 
> > LGTM
> 
> @Manvel  Just found out part of the text from one of the source strings was
> removed (Check it out for yourself) and the code for the hyperlink moved to
> affect different words. Unfortunately, no one told me and the translations
still
> have that part of the text with also the hyperlink tags.
> 
> I will fix them on Crowdin to make sure they are consistent with the English.
> 
> Sorry about this.

Not sure which word text you mean (But sounds like it's easy to fix?), you want
me to make it part of https://codereview.adblockplus.org/29683559/ or create a
separate ticket for that ?

[tamara, 2018-01-30 12:31:03]

On 2018/01/30 12:24:54, saroyanm wrote:
> On 2018/01/29 18:28:09, tamara wrote:
> > On 2018/01/24 13:41:43, tamara wrote:
> > > On 2018/01/24 13:26:37, saroyanm wrote:
> > > > On 2018/01/24 12:07:29, tamara wrote:
> > > > > On 2018/01/24 11:58:40, saroyanm wrote:
> > > > > > On 2018/01/24 10:58:36, tamara wrote:
> > > > > > > On 2018/01/24 10:56:27, tamara wrote:
> > > > > > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > > > > > Tamara can you please have a look and let me know if I can
give
> a
> > > go.
> > > > > > > > > 
> > > > > > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in
> order
> > to
> > > > > keep
> > > > > > > the
> > > > > > > > > links in place.
> > > > > > > > 
> > > > > > > > Hey Manvel,
> > > > > > > > 
> > > > > > > > Is there any reason why the string with "Version ####" is
missing?
> > Out
> > > > of
> > > > > > the
> > > > > > > > languages I've reviewed so far, none of them has that one.  :-/
> > > > > > > 
> > > > > > > Also, the specific string we had only for German is missing in the
> > code
> > > > > review
> > > > > > > for that language. I guess that's normal in this case, no?
> > > > > > 
> > > > > > I can't see that string in the specification, so either it was
> removed,
> > or
> > > > > never
> > > > > > specified. @wspee?
> > > > > >
> https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> > > > > 
> > > > > The one that says "Section 2: For German users"
> > > > 
> > > > Well spotted, I missed that one. New patch is uploaded.
> > > 
> > > All reviewed now!
> > > 
> > > LGTM
> > 
> > @Manvel  Just found out part of the text from one of the source strings was
> > removed (Check it out for yourself) and the code for the hyperlink moved to
> > affect different words. Unfortunately, no one told me and the translations
> still
> > have that part of the text with also the hyperlink tags.
> > 
> > I will fix them on Crowdin to make sure they are consistent with the
English.
> > 
> > Sorry about this.
> 
> Not sure which word text you mean (But sounds like it's easy to fix?), you
want
> me to make it part of https://codereview.adblockplus.org/29683559/ or create a
> separate ticket for that ?

The original string was: "Brand new Settings page - revamped and restyled with
more privacy and security options - so it's easier to customize Adblock Plus
just like you want it. [Check it out for yourself.]" However, the last part
"[Check it out for yourself.]" was removed without my knowledge.

It is easy to fix for those languages I can read, not the other ones as I won't
know then where the tags are supposed to go. I'll try to have that ready today.

Regarding the codereview, I'd rather if you made a separate ticket once I've
finished fixing the strings or just leave it as it currently is. As I might not
be able to have a look at https://codereview.adblockplus.org/29683559/ this
week, it won't make sense to include it there either.

[tamara, 2018-02-22 15:05:26]

On 2018/01/30 12:31:03, tamara wrote:
> On 2018/01/30 12:24:54, saroyanm wrote:
> > On 2018/01/29 18:28:09, tamara wrote:
> > > On 2018/01/24 13:41:43, tamara wrote:
> > > > On 2018/01/24 13:26:37, saroyanm wrote:
> > > > > On 2018/01/24 12:07:29, tamara wrote:
> > > > > > On 2018/01/24 11:58:40, saroyanm wrote:
> > > > > > > On 2018/01/24 10:58:36, tamara wrote:
> > > > > > > > On 2018/01/24 10:56:27, tamara wrote:
> > > > > > > > > On 2018/01/22 09:19:53, saroyanm wrote:
> > > > > > > > > > Tamara can you please have a look and let me know if I can
> give
> > a
> > > > go.
> > > > > > > > > > 
> > > > > > > > > > I replaced "[" and "]" with "<a>" and "</a>" accordingly in
> > order
> > > to
> > > > > > keep
> > > > > > > > the
> > > > > > > > > > links in place.
> > > > > > > > > 
> > > > > > > > > Hey Manvel,
> > > > > > > > > 
> > > > > > > > > Is there any reason why the string with "Version ####" is
> missing?
> > > Out
> > > > > of
> > > > > > > the
> > > > > > > > > languages I've reviewed so far, none of them has that one. 
:-/
> > > > > > > > 
> > > > > > > > Also, the specific string we had only for German is missing in
the
> > > code
> > > > > > review
> > > > > > > > for that language. I guess that's normal in this case, no?
> > > > > > > 
> > > > > > > I can't see that string in the specification, so either it was
> > removed,
> > > or
> > > > > > never
> > > > > > > specified. @wspee?
> > > > > > >
> > https://gitlab.com/eyeo/spec/blob/updates_page/spec/abp/updates-page.md
> > > > > > 
> > > > > > The one that says "Section 2: For German users"
> > > > > 
> > > > > Well spotted, I missed that one. New patch is uploaded.
> > > > 
> > > > All reviewed now!
> > > > 
> > > > LGTM
> > > 
> > > @Manvel  Just found out part of the text from one of the source strings
was
> > > removed (Check it out for yourself) and the code for the hyperlink moved
to
> > > affect different words. Unfortunately, no one told me and the translations
> > still
> > > have that part of the text with also the hyperlink tags.
> > > 
> > > I will fix them on Crowdin to make sure they are consistent with the
> English.
> > > 
> > > Sorry about this.
> > 
> > Not sure which word text you mean (But sounds like it's easy to fix?), you
> want
> > me to make it part of https://codereview.adblockplus.org/29683559/ or create
a
> > separate ticket for that ?
> 
> The original string was: "Brand new Settings page - revamped and restyled with
> more privacy and security options - so it's easier to customize Adblock Plus
> just like you want it. [Check it out for yourself.]" However, the last part
> "[Check it out for yourself.]" was removed without my knowledge.
> 
> It is easy to fix for those languages I can read, not the other ones as I
won't
> know then where the tags are supposed to go. I'll try to have that ready
today.
> 
> Regarding the codereview, I'd rather if you made a separate ticket once I've
> finished fixing the strings or just leave it as it currently is. As I might
not
> be able to have a look at https://codereview.adblockplus.org/29683559/ this
> week, it won't make sense to include it there either.

LGTM