Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29713586: Issue 6439 - fix emscripten CI for osx (Closed)

Created:
March 2, 2018, 3:19 p.m. by sergei
Modified:
March 6, 2018, 3:46 p.m.
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M .travis.yml View 1 chunk +2 lines, -1 line 0 comments Download
M .travis/travis-before_script.sh View 1 chunk +6 lines, -3 lines 1 comment Download
M .travis/travis-install.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
sergei
https://codereview.adblockplus.org/29713586/diff/29713587/.travis/travis-before_script.sh File .travis/travis-before_script.sh (left): https://codereview.adblockplus.org/29713586/diff/29713587/.travis/travis-before_script.sh#oldcode5 .travis/travis-before_script.sh:5: set -x It is no sense to enable the ...
March 2, 2018, 3:34 p.m. (2018-03-02 15:34:21 UTC) #1
sergei
Can we please prioritize it? Without that patch any next commit will be marked as ...
March 5, 2018, 10:33 a.m. (2018-03-05 10:33:50 UTC) #2
sergei
Could someone please review it? There are already few approved changes but they cannot be ...
March 6, 2018, 8:07 a.m. (2018-03-06 08:07:22 UTC) #3
hub
March 6, 2018, 2:46 p.m. (2018-03-06 14:46:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld