Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 29716681: Issue 6454 - IllegalStateException crash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by diegocarloslima
Modified:
1 year, 8 months ago
Reviewers:
jens, René Jeschke, anton
Visibility:
Public.

Description

Issue 6454 - IllegalStateException crash

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add final modifiers and renamed removeOnEngineCreatedCallback #

Total comments: 1

Patch Set 3 : Adjusting engine check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -345 lines) Patch
M adblockplussbrowser/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java View 3 chunks +5 lines, -5 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java View 2 chunks +3 lines, -3 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java View 4 chunks +87 lines, -81 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java View 1 9 chunks +28 lines, -12 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java View 1 2 7 chunks +24 lines, -15 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java View 3 chunks +20 lines, -18 lines 0 comments Download
M adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 8 chunks +18 lines, -20 lines 0 comments Download
A adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java View 1 1 chunk +142 lines, -0 lines 0 comments Download
R adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java View 1 chunk +0 lines, -189 lines 0 comments Download

Messages

Total messages: 7
diegocarloslima
1 year, 8 months ago (2018-03-07 20:34:40 UTC) #1
jens
On 2018/03/07 20:34:40, diegocarloslima wrote: I have tested it and it works well! Only one ...
1 year, 8 months ago (2018-03-08 09:18:32 UTC) #2
jens
https://codereview.adblockplus.org/29716681/diff/29716682/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java (right): https://codereview.adblockplus.org/29716681/diff/29716682/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java#newcode28 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java:28: I didn't want to leave a lot of single ...
1 year, 8 months ago (2018-03-08 09:18:40 UTC) #3
diegocarloslima
About the nullchecks for the engine, no I didn't experience any crash. I just added ...
1 year, 8 months ago (2018-03-08 11:54:35 UTC) #4
jens
https://codereview.adblockplus.org/29716681/diff/29716682/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java File adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java (right): https://codereview.adblockplus.org/29716681/diff/29716682/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java#newcode28 adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java:28: On 2018/03/08 11:54:34, diegocarloslima wrote: > On 2018/03/08 09:18:40, ...
1 year, 8 months ago (2018-03-08 12:33:55 UTC) #5
jens
On 2018/03/08 12:33:55, jens wrote: > https://codereview.adblockplus.org/29716681/diff/29716682/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java > File > adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineManager.java > (right): > > ...
1 year, 8 months ago (2018-03-08 16:19:38 UTC) #6
René Jeschke
1 year, 8 months ago (2018-03-09 10:11:03 UTC) #7
LGTM

https://codereview.adblockplus.org/29716681/diff/29717591/adblockplussbrowser...
File
adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java
(right):

https://codereview.adblockplus.org/29716681/diff/29717591/adblockplussbrowser...
adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java:129:
else if (sub.getType() == SubscriptionInfo.Type.CUSTOM && engine != null)
NIT: Unrelated change, but I don't mind. It's up to you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5