Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 29721697: Noissue - fix support of namespace, external user-config.h and debug configuration (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by sergei
Modified:
3 months ago
Base URL:
https://github.com/adblockplus/adblockpluscore.git@caf1800ce0342583de4c0320745f0fdb3b55bd01
Visibility:
Public.

Description

This commit consists from barely separable changes which are: - add missing header <locale> which is required on linux for std::wstring_convert - add missing ABP_NS in few places - fix wrong type of the second argument for assert2 - use corresponding compiler arguments for debug buildtype - implement missing Log* functions for tests because otherwise tests cannot be linked - add compilation (with following run of the tests) with external user-config-test-namespace.h which also defines a custom namespace. Review: https://codereview.adblockplus.org/29721697

Patch Set 1 #

Patch Set 2 : get rid of the warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M .travis/travis-script.sh View 1 chunk +5 lines, -0 lines 0 comments Download
M compiled/Map.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M compiled/String.h View 1 chunk +1 line, -0 lines 0 comments Download
M compiled/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M compiled/library.h View 1 chunk +3 lines, -3 lines 0 comments Download
M compiled/library.cpp View 1 chunk +1 line, -1 line 0 comments Download
M meson.build View 2 chunks +2 lines, -1 line 0 comments Download
A + test/compiled/library.cpp View 1 chunk +21 lines, -4 lines 0 comments Download
A + test/compiled/user-config-test-namespace.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4
sergei
3 months ago (2018-03-13 16:41:26 UTC) #1
hub
LGTM
3 months ago (2018-03-13 16:50:19 UTC) #2
sergei
I have spotted the warning, the patchset is updated, CI is not finished though.
3 months ago (2018-03-13 18:19:15 UTC) #3
hub
3 months ago (2018-03-13 21:30:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5